Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the coordinator check inputs as far as possible? #29

Open
real-or-random opened this issue Jun 28, 2024 · 1 comment
Open

Should the coordinator check inputs as far as possible? #29

real-or-random opened this issue Jun 28, 2024 · 1 comment

Comments

@real-or-random
Copy link
Collaborator

real-or-random commented Jun 28, 2024

This is related to #9, but only somewhat.

At the moment, the coordinator mostly just relays messages. The verification of the messages is left to the participants, who need to perform it anyway. The coordinator could also check messages. Would this provide any advantages?

@jonasnick
Copy link
Collaborator

Some notes after discussing this offline:

The advantage this would provide is that a potential bug would surface earlier. Also, the participant could replace the ParticipantOrCoordinatorError with a CoordinatorError in every case except when the received share is inconsistent with the VSS commitment.

The disadvantages are:

  • Increased complexity of the coordinator.
  • Duplicate checks. The participants still need to do the same checks they do right now. Duplicate checks lead to a (probably insignificant) runtime increase.

My current stance is that I am not in favor of this change because of the increased complexity and duplicate checks. If implementors have the desire to make their coordinator check inputs as far as possible, they're free to do so because this would still be consistent with the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants