Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with ESP32-Wrover-Cam + Waveshare Pico 1.14 LCD Hat (worked with previous versions) #166

Closed
Drew72-ita opened this issue Sep 24, 2024 · 13 comments

Comments

@Drew72-ita
Copy link

Drew72-ita commented Sep 24, 2024

Hi,

It's been a year now that I successfully used one DIY Jade, hardware
ESP32-Wrover-Cam + Waveshare Pico 1.14 LCD Hat
(see https://github.com/Blockstream/Jade/tree/master/diy/esp32-wrover-cam#connection-diagram)

Building and flashing newer version of the software always went fine, I am using the config
cp configs/sdkconfig_diycam_esp32-wrover-cam.defaults sdkconfig.defaults

The newest version(s) [I updated last time 3-4 months ago] of the Jade software successfully builds and flashes as usual but I am left with an unusable Jade due to a graphic glitch of some sort (see picture attached).

Please note that:

  1. The hardware was working fine (LCD, buttons, functions) just before the flashing the new built version of Jade
  2. The same issue was reported to me 2-3 months ago, it was apparently solved with a slightly different ESP32-WROVER CAM Board (I remember something about the SD slot)

Jade-wrovercam_KO

@greenaddress
Copy link
Contributor

@Drew72-ita unfortunately we don't have a ESP32-Wrover-Cam + Waveshare Pico 1.14 LCD Hat

Generally we try to support all DIY devices we have access to personally flash to and try not to break others but ultimately we can't test every combination. Maybe some other DIY contributor can help reproduce/find the problem.

Recently we changed the display library, the sdkconfig.default or Kconfig may require some tweaking.

@Drew72-ita
Copy link
Author

@greenaddress TY for the info.

FYI I rolled back to
eps-idf 5.1.2 (482a8fb2d78e3b58eb21b26da8a5bedf90623213)
+
jade 1.0.29
and it works again.

(since from memory this was my last working version - but I was not updating this jade since some months)

@Drew72-ita
Copy link
Author

@greenaddress

FYI it works fine also with
eps-idf 5.1.3 (e7771c75bd1dbbfb7b3c5381be7e063b197c9734)
+
jade 1.0.30

So the issue was effectively introduced with version 1.0.31, consistent with the note that appears in jade/CHANGELOG.md:
Change UI graphics library to esp_lcd

@Drew72-ita
Copy link
Author

Should you need to test something on this hardware, let me know.

@greenaddress
Copy link
Contributor

@Drew72-ita in your local repo you could try changing the line https://github.com/Blockstream/Jade/blob/master/main/display_hw.c#L195

try all the combinations:
true, true;
false, false;
true, false;
false, true;

once we have which combo works we should be able to fix the config.

If it's not that it could be instead be related to https://github.com/Blockstream/Jade/blob/master/main/display_hw.c#L190 or yet again https://github.com/Blockstream/Jade/blob/master/main/display_hw.c#L204 but let's try one thing at the time.

@greenaddress
Copy link
Contributor

maybe @3rdIteration can also provide some guidance

@Drew72-ita
Copy link
Author

Drew72-ita commented Sep 26, 2024

@greenaddress
Tried all possible combinations in
https://github.com/Blockstream/Jade/blob/master/main/display_hw.c#L195
and no difference of any sort.

Note: between each edit of main/display_hw.c I cleaned, built and flashed
idf.py clean
idf.py build
idf.py flash

on the last iteration ( false, true ) I gather the output from a idf.py monitor, but probably it is not useful for you
[edit 27/9/24: log removed - ask if needed]

@3rdIteration
Copy link
Contributor

I have one on hand here, so I'll have a look in the next day or so. :)

@3rdIteration
Copy link
Contributor

I can verify that I have reproduced the issue, it is fixed by editing the config using menuconfig and editing the following from the profile in the repo.

  • Invert colours
  • Mirror X
  • Swap X and Y

Once you do this then everything works as expected

@Drew72-ita
Copy link
Author

@greenaddress
I successfully reproduced this fix on my hardware, thank you very much @3rdIteration ! ^__^

@greenaddress
Copy link
Contributor

thanks @3rdIteration for finding the problem and thanks @Drew72-ita from catching it and testing it, will look at updating the config file to reflect those changes

@JamieDriver
Copy link
Collaborator

Cheers guys, this has been merged into master.
Please close if you agree the issue is resolved.
Many thanks.

@Drew72-ita
Copy link
Author

Re-tested a fresh install on a pristine installation - current checkout version of jade works fine on this hardware build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants