Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jade crashes when attempting to select 24 words BIP85 with index # > 1230 #149

Closed
totallynarwhal opened this issue Aug 12, 2024 · 7 comments

Comments

@totallynarwhal
Copy link

totallynarwhal commented Aug 12, 2024

On firmware 1.0.30, when I attempt to use a 24 words BIP85 index # greater than 1230, it crashes the Jade device resulting in a reboot.

Repro steps:

  1. Select manual BIP39 Passphrase with Frequence Once
  2. QR Pin Unlock with Blockstream's blind oracle, i.e. blkstrm.com/pn
  3. Enter Passphrase to start session
  4. Go to Wallet->BIP85 and choose 24 Words option
  5. Use jog-wheel to increment index # towards 2000

[Expected]
I'm able to navigate and select a BIP85 index that's fairly large, i.e. 2000

[Actual]
When I navigate to ~1230, if I continue to press and hold the jog-wheel, I'll start to get garbled text in the ones and then attempting to increment the index further would then crash and reboot the device.

image

Note: This seems to only be an issue when holding down the jog-wheel, it appears that I was still able to slowly increment the index if I push the jog-wheel right but not hold. But this means I don't have the ability to fast increment! I'm still pretty far away from index 2000 :(

@totallynarwhal
Copy link
Author

totallynarwhal commented Aug 12, 2024

On a related note - having to use the jog-wheel to manually incremental the index # via the carousel UX is also pretty tedious for large index #... it'll be great if we have a UX similar to entering the unlock pin.

@JamieDriver
Copy link
Collaborator

Yes, not sure what's going on there - maybe the wheel is generating events faster than they are being consumed and so eventually we run out of [some sort of] RAM or similar. I'll try to reproduce.

Definitely agree a better way to enter large index #'s is needed.

@JamieDriver
Copy link
Collaborator

Will investigate using the 'pin-entry' type screens... ie. where you set each digit in turn

@JamieDriver
Copy link
Collaborator

eg:

IMG_20240820_165913279

@JamieDriver
Copy link
Collaborator

Will switch to above for next fw release 1.0.32

@totallynarwhal
Copy link
Author

Updated to allow index up to 999999 as well - awesome!

@JamieDriver
Copy link
Collaborator

Should be resolved in fw 1.0.32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants