Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 1.15.1 #12

Open
Lusteroth opened this issue Dec 22, 2019 · 18 comments · Fixed by #11
Open

Support for 1.15.1 #12

Lusteroth opened this issue Dec 22, 2019 · 18 comments · Fixed by #11

Comments

@Lusteroth
Copy link

Is it possible to upload a JAR supporting version 1.15.1? I saw the github code got updated but I didn't find a created jar.

@BlackScarx
Copy link
Owner

I'm at hospital at this time.
I can't create jar from my phone.
I'll be back soon

@Lusteroth
Copy link
Author

Get well soon!

@ShayPunter
Copy link

Hello @Lusteroth,

You can download a jar directly from the pull request I made to add support for 1.15.X: #11 (comment)

@hcshires
Copy link

hcshires commented May 8, 2020

Here is the jar so you don't have to comment on the pull request

https://github.com/BlackScarx/BetterChairs/files/3992310/BetterChairs.zip

@BrettPlays
Copy link

BrettPlays commented May 11, 2020

Still seems to be disabling itself:
`

.... [19:31:44 INFO]: [BetterChairs] Enabling BetterChairs v0.10.1*
.... [19:31:44 INFO]: [BetterChairs] Your server is running version v1_15_R1
.... [19:31:44 ERROR]: [BetterChairs] Failed to setup nms !
.... [19:31:44 ERROR]: [BetterChairs] Your server version is not compatible with this plugin!
.... [19:31:44 INFO]: [BetterChairs] Disabling BetterChairs v0.10.1`

@hcshires
Copy link

What specific version of Spigot are you on?

@SpraxDev
Copy link
Collaborator

Could you try this .jar?
https://github.com/Sprax2013/BetterChairs/suites/669425588/artifacts/6004830

If it still fails please tell run /version and tell us it's output.

My jar nearly contains the same code. I just moved it to use Maven. Still needs some optimization, code cleanup/recoding and testing.
Gonna create a PR when done but still need to talk with the original author about it.

@hcshires
Copy link

hcshires commented May 11, 2020

Oh awesome glad you did that. I realized that before I submitted mine and that I probably should've done that but thx for doing it anyway. I'll test it as well.

@SpraxDev
Copy link
Collaborator

Thanks :) - Open for feedback! First time splitting all those NMS dependencies into their own modules. Still need to clean that up and apply some cleanup to my code or 1.8 - 1.15 compatibility. But weird that the provided jar in #11 doesn't seem to work as it is included in my code as well

This was linked to pull requests May 11, 2020
@hcshires
Copy link

hcshires commented May 11, 2020

Interesting. Contrary to Brett, I was able to get #11 's working on my server. Might be a client-side issue. Additionally, are you able to update the spigot page when a production jar is ready?

@SpraxDev
Copy link
Collaborator

SpraxDev commented May 11, 2020

I contacted @BlackScarx about continuing the project and do some updates and optimization. I'll do them anyway but keeping the download page up-to-date would be great and seeing it without those large, red lines saying it won't get any updates, except support for new version is kind of sad looking.

So currently I can't as I don't have access to it on SpigotMC.org but I'm hoping of getting them and polish everything a bit ^^

@hcshires
Copy link

True dat XD. Sounds good

@hcshires
Copy link

Oh yea one more question: I noticed on my server the new stair blocks introduced in newer versions like 1.14 maybe don't work. I'm assuming that's due to lack of version support but since you want to have backwards compatibility, is that something that can be fixed?

@SpraxDev
Copy link
Collaborator

It sure can is going to be. The earliest I can do is next Saturday sadly. As my changes are getting out of hand already I won't merge into this repository as planned, as I had to rewrite all of git history. But my plans on updating the Spigot-Page still exist!

Saturday I'll probably start actually recoding all the classes.

  1. I'll move and rename most/all the classes but want to ensure that other plugins relying on BetterChairs still work with my fork
  2. I want to support all version from 1.8 onward
  3. I want to introduce a new configuration file and automatically upgrade old ones

@hcshires
Copy link

Awesome

@LuisOficial
Copy link

It sure can is going to be. The earliest I can do is next Saturday sadly. As my changes are getting out of hand already I won't merge into this repository as planned, as I had to rewrite all of git history. But my plans on updating the Spigot-Page still exist!

Saturday I'll probably start actually recoding all the classes.

  1. I'll move and rename most/all the classes but want to ensure that other plugins relying on BetterChairs still work with my fork
  2. I want to support all version from 1.8 onward
  3. I want to introduce a new configuration file and automatically upgrade old ones

Can you pass your discord to be attentive to the updates of this plugins?

@SpraxDev
Copy link
Collaborator

Can you pass your discord to be attentive to the updates of this plugins?

I'll give support for it on my own Discord server https://sprax.me/discord

@SpraxDev
Copy link
Collaborator

SpraxDev commented Jun 5, 2020

Current status and new version in #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants