Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] command base is partially synchronous #314

Open
SIMULATAN opened this issue Feb 19, 2023 · 0 comments
Open

[BUG] command base is partially synchronous #314

SIMULATAN opened this issue Feb 19, 2023 · 0 comments
Assignees
@SIMULATAN
Labels
bug Something isn't working
Milestone
v2

Comments

@SIMULATAN
Copy link
Member

Describe the bug
Right now, only the execution of the command itself is async.
However, loading the user settings, which is the longest part as it involves I/O, is happening in the ws thread. This could lead to discord timeouts in the future.

Expected behavior
The whole code in onCommandInteraction should be sent to the thread pool, not only the execution of the command itself.
@SIMULATAN SIMULATAN added the bug Something isn't working label Feb 19, 2023
@SIMULATAN SIMULATAN added this to the v2 milestone Feb 19, 2023
@SIMULATAN SIMULATAN self-assigned this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SIMULATAN SIMULATAN

Labels
bug Something isn't working
Projects
BlackOnion-Bot
Status: Todo
Milestone
v2
Development

No branches or pull requests
1 participant
@SIMULATAN