refactor(wp): send many uniform error messages changes #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krupanand-bitgo
force-pushed
the
COIN-1957_send_many_error_message
branch
4 times, most recently
from
7f364a1 to
598f405
Compare
alebusse
previously approved these changes
Dec 3, 2024
mukeshsp
previously approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Do we need this pr and https://github.com/BitGo/bitgo-microservices/pull/44632 ??
krupanand-bitgo
dismissed stale reviews from mukeshsp and alebusse
via
9e2d100
krupanand-bitgo
force-pushed
the
COIN-1957_send_many_error_message
branch
4 times, most recently
from
70ca339 to
a90cccb
Compare
therealdwright
previously approved these changes
Dec 5, 2024
krupanand-bitgo
force-pushed
the
COIN-1957_send_many_error_message
branch
from
a90cccb to
839b167
Compare
Yes. |
krupanand-bitgo
requested review from
mukeshsp,
therealdwright,
alebusse and
zahin-mohammad
alebusse
reviewed
Dec 5, 2024
krupanand-bitgo
force-pushed
the
COIN-1957_send_many_error_message
branch
2 times, most recently
from
8e53c0a to
d60b0fa
Compare
zahin-mohammad
previously approved these changes
Dec 6, 2024
krupanand-bitgo
force-pushed
the
COIN-1957_send_many_error_message
branch
from
d60b0fa to
b97eb08
Compare
krupanand-bitgo
force-pushed
the
COIN-1957_send_many_error_message
branch
3 times, most recently
from
27ed6c5 to
e13b12a
Compare
krupanand-bitgo
force-pushed
the
COIN-1957_send_many_error_message
branch
from
e13b12a to
fd59b8f
Compare
mukeshsp
approved these changes
Dec 9, 2024
margueriteblair
approved these changes
Dec 9, 2024
alebusse
approved these changes
Dec 9, 2024
zahin-mohammad
approved these changes
Dec 9, 2024
therealdwright
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardized error messages for the Bulk Withdrawal API across different assets to ensure consistency.
Ticket: COIN-1957