From 821e7078da6869cfc43605e824639bc2f3dec77e Mon Sep 17 00:00:00 2001 From: SanHalacogluImproving Date: Mon, 16 Oct 2023 15:55:46 -0700 Subject: [PATCH 1/3] Updated ClientCount to client_count for uniformity. --- benchmarks/node/node_benchmark.ts | 2 +- benchmarks/python/python_benchmark.py | 2 +- benchmarks/utilities/csv_exporter.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/benchmarks/node/node_benchmark.ts b/benchmarks/node/node_benchmark.ts index c2a493b517..5921f9cf0e 100644 --- a/benchmarks/node/node_benchmark.ts +++ b/benchmarks/node/node_benchmark.ts @@ -167,7 +167,7 @@ async function run_clients( num_of_tasks: num_of_concurrent_tasks, data_size, tps, - clientCount: clients.length, + client_count: clients.length, is_cluster, ...set_latency_results, ...get_existing_latency_results, diff --git a/benchmarks/python/python_benchmark.py b/benchmarks/python/python_benchmark.py index 2fa30c56d6..0871c231c7 100644 --- a/benchmarks/python/python_benchmark.py +++ b/benchmarks/python/python_benchmark.py @@ -226,7 +226,7 @@ async def run_clients( "num_of_tasks": num_of_concurrent_tasks, "data_size": data_size, "tps": tps, - "clientCount": len(clients), + "client_count": len(clients), "is_cluster": is_cluster, }, **get_existing_latency_results, diff --git a/benchmarks/utilities/csv_exporter.py b/benchmarks/utilities/csv_exporter.py index a9f1131729..31b512944f 100644 --- a/benchmarks/utilities/csv_exporter.py +++ b/benchmarks/utilities/csv_exporter.py @@ -12,7 +12,7 @@ "is_cluster", "num_of_tasks", "data_size", - "clientCount", + "client_count", "tps", "get_non_existing_p50_latency", "get_non_existing_p90_latency", From 2e81456f04bb23f74285223b3d32f62bb67826f4 Mon Sep 17 00:00:00 2001 From: SanHalacogluImproving Date: Tue, 17 Oct 2023 09:19:58 -0700 Subject: [PATCH 2/3] Updated ClientCount to client_count for uniformity for csharp. --- benchmarks/csharp/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmarks/csharp/Program.cs b/benchmarks/csharp/Program.cs index f37c4baf74..6144c5244e 100644 --- a/benchmarks/csharp/Program.cs +++ b/benchmarks/csharp/Program.cs @@ -226,7 +226,7 @@ int num_of_concurrent_tasks {"num_of_tasks", num_of_concurrent_tasks}, {"data_size", data_size}, {"tps", tps}, - {"clientCount", clients.Length}, + {"client_count", clients.Length}, {"is_cluster", "false"} }; result = result From 20d05c8c00bef10756293e0b678e11d048fa3de6 Mon Sep 17 00:00:00 2001 From: SanHalacogluImproving Date: Wed, 18 Oct 2023 14:18:17 -0700 Subject: [PATCH 3/3] Updated ClientCount to client_count for uniformity for rust. --- benchmarks/rust/src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmarks/rust/src/main.rs b/benchmarks/rust/src/main.rs index cca484b945..bc934f74e6 100644 --- a/benchmarks/rust/src/main.rs +++ b/benchmarks/rust/src/main.rs @@ -130,7 +130,7 @@ async fn perform_benchmark(args: Args) { Value::Number((number_of_operations as i64 * 1000 / stopwatch.elapsed_ms()).into()), ); results_json.insert( - "clientCount".to_string(), + "client_count".to_string(), Value::Number(args.client_count.into()), ); results_json.insert(