From a62b9fe52149aeda304bb3ad8a11f6ad40270be2 Mon Sep 17 00:00:00 2001 From: aaron-congo Date: Tue, 27 Feb 2024 14:19:05 -0800 Subject: [PATCH] PR suggestions --- .github/workflows/go.yml | 12 +++--------- go/Makefile | 8 ++++++-- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 0e18b436fa..f05fe92def 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -29,8 +29,8 @@ jobs: fail-fast: false matrix: go: - - '1.18' - - '1.22' + - '1.18.10' + - '1.22.0' redis: - 6.2.14 - 7.2.3 @@ -141,14 +141,8 @@ jobs: echo "$HOME/go/bin" >> $GITHUB_PATH - name: Install tools for Go ${{ matrix.go }} - if: ${{ matrix.go == '1.18.10' }} working-directory: ./go - run: make install-tools-go1.18 - - - name: Install tools for Go ${{ matrix.go }} - if: ${{ matrix.go == '1.22.0' }} - working-directory: ./go - run: make install-tools-go1.22 + run: make install-tools-go${{ matrix.go }} - name: Build client working-directory: ./go diff --git a/go/Makefile b/go/Makefile index acc3c059b1..8166d4f359 100644 --- a/go/Makefile +++ b/go/Makefile @@ -13,9 +13,13 @@ install-dev-tools-go1.22: go install github.com/segmentio/golines@v0.12.2 go install honnef.co/go/tools/cmd/staticcheck@v0.4.6 -install-tools-go1.18: install-build-tools install-dev-tools-go1.18 +install-dev-tools: install-dev-tools-go1.22 -install-tools-go1.22: install-build-tools install-dev-tools-go1.22 +install-tools-go1.18.10: install-build-tools install-dev-tools-go1.18 + +install-tools-go1.22.0: install-build-tools install-dev-tools-go1.22 + +install-tools: install-tools-go1.22.0 build: build-glide-core build-glide-client generate-protobuf go build ./...