From 36452b77ab2a0647efd9c87b89929ba4ef8ee441 Mon Sep 17 00:00:00 2001 From: Joseph Brinkman Date: Tue, 17 Dec 2024 20:12:12 -0500 Subject: [PATCH] remove native package references for MacOS x64 architecture (#2824) * remove native package references for MacOS x64 architecture Signed-off-by: jbrinkman --- CHANGELOG.md | 5 +++++ node/npm/glide/index.ts | 3 --- node/npm/glide/package.json | 1 - 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1f8ebb2985..f820f45e05 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,8 @@ #### Changes + * Java: Bump protobuf (protoc) version ([#2561](https://github.com/valkey-io/valkey-glide/pull/2561), [#2802](https://github.com/valkey-io/valkey-glide/pull/2802) * Java: bump `netty` version ([#2777](https://github.com/valkey-io/valkey-glide/pull/2777)) +* Node: Remove native package references for MacOs x64 architecture ([#2799](https://github.com/valkey-io/valkey-glide/issues/2799)) #### Breaking Changes @@ -13,6 +15,7 @@ ## 1.2.0 (2024-11-27) #### Changes + * Node: Client API for retrieving internal statistics ([#2727](https://github.com/valkey-io/valkey-glide/pull/2727)) * Python: Client API for retrieving internal statistics ([#2707](https://github.com/valkey-io/valkey-glide/pull/2707)) * Node, Python, Java: Adding support for replacing connection configured password ([#2651](https://github.com/valkey-io/valkey-glide/pull/2651), [#2659](https://github.com/valkey-io/valkey-glide/pull/2659), [#2677](https://github.com/valkey-io/valkey-glide/pull/2677)) @@ -107,7 +110,9 @@ #### Breaking Changes + #### Fixes + * Core: UDS Socket Handling Rework ([#2482](https://github.com/valkey-io/valkey-glide/pull/2482)) #### Operational Enhancements diff --git a/node/npm/glide/index.ts b/node/npm/glide/index.ts index da719c51c7..c4dab9795b 100644 --- a/node/npm/glide/index.ts +++ b/node/npm/glide/index.ts @@ -53,9 +53,6 @@ function loadNativeBinding() { break; case "darwin": switch (arch) { - case "x64": - nativeBinding = require("@scope/valkey-glide-darwin-x64"); - break; case "arm64": nativeBinding = require("@scope/valkey-glide-darwin-arm64"); break; diff --git a/node/npm/glide/package.json b/node/npm/glide/package.json index 78ec8d0821..8444de8ef9 100644 --- a/node/npm/glide/package.json +++ b/node/npm/glide/package.json @@ -41,7 +41,6 @@ }, "optionalDependencies": { "${scope}valkey-glide-darwin-arm64": "${package_version}", - "${scope}valkey-glide-darwin-x64": "${package_version}", "${scope}valkey-glide-linux-arm64": "${package_version}", "${scope}valkey-glide-linux-x64": "${package_version}", "${scope}valkey-glide-linux-musl-arm64": "${package_version}",