From 006e2ce8c6ebad854e8d9c7a005840e756caecd7 Mon Sep 17 00:00:00 2001 From: aaron-congo Date: Mon, 4 Mar 2024 17:41:49 -0800 Subject: [PATCH] Check lint error output --- .github/workflows/go.yml | 11 ++++------- go/Makefile | 4 +--- go/api/config.go | 3 +-- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 0b24deb219..474bd5e0ca 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -64,17 +64,14 @@ jobs: working-directory: ./go run: make install-tools-go${{ matrix.go }} - - name: Build client - working-directory: ./go - run: make build - - - name: Setup upterm session - uses: lhotari/action-upterm@v1 - - name: Run linters working-directory: ./go run: make lint-ci + - name: Build client + working-directory: ./go + run: make build + - name: Run tests working-directory: ./go run: make test-and-report diff --git a/go/Makefile b/go/Makefile index 1ec0145dfd..cc03565a08 100644 --- a/go/Makefile +++ b/go/Makefile @@ -46,9 +46,7 @@ lint: gofumpt -d . golines --dry-run --shorten-comments -m 127 . -lint-ci: - go vet ./... - staticcheck ./... +lint-ci: lint if [ "$$(gofumpt -l . | wc -l)" -gt 0 ]; then exit 1; fi if [ "$$(golines -l --shorten-comments -m 127 . | wc -l)" -gt 0 ]; then exit 1; fi diff --git a/go/api/config.go b/go/api/config.go index 9d2417b429..82d6000104 100644 --- a/go/api/config.go +++ b/go/api/config.go @@ -240,8 +240,7 @@ type RedisClusterClientConfiguration struct { baseClientConfiguration } -// NewRedisClusterClientConfiguration returns a [RedisClusterClientConfiguration] with default configuration settings. For -// further configuration, use the [RedisClientConfiguration] With* methods. +// NewRedisClusterClientConfiguration returns a [RedisClusterClientConfiguration] with default configuration settings. For further configuration, use the [RedisClientConfiguration] With* methods. func NewRedisClusterClientConfiguration() *RedisClusterClientConfiguration { return &RedisClusterClientConfiguration{ baseClientConfiguration: baseClientConfiguration{},