Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing loading state on Pool page #97

Open
gjj opened this issue Aug 11, 2022 · 3 comments
Open

Showing loading state on Pool page #97

gjj opened this issue Aug 11, 2022 · 3 comments
Labels
area/pool For liquidity pool components, including homepage area/ui-ux For all UI/UX enhancement requests kind/feature New feature request needs/triage Waiting for triage to be accepted priority/important-soon Will be important soon

Comments

@gjj
Copy link
Contributor

gjj commented Aug 11, 2022

What would you like to be added:

When the dApp is first loaded without any wallet connection, we're not showing a loading state. Should have that loading state just in case of Infura downtime.

Why is this needed:

@gjj gjj added kind/feature New feature request priority/important-soon Will be important soon area/pool For liquidity pool components, including homepage labels Aug 11, 2022
@birthdayresearch-bot
Copy link

@gjj: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the BirthdayResearch developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@birthdayresearch-bot birthdayresearch-bot added the needs/triage Waiting for triage to be accepted label Aug 11, 2022
@gjj gjj added the area/ui-ux For all UI/UX enhancement requests label Aug 11, 2022
@Abhishekkochar
Copy link
Contributor

Hi @gjj, This feature has already been implemented here. Let me know if this is what you are referring to.

@gjj
Copy link
Contributor Author

gjj commented Aug 15, 2022

image

Am aware of that! Was referring to this initial state instead -- on page load where it'll be empty, as I removed that initially when working on #93

We should show the loading state -- same as before, just in case Infura fails to load, so users will not be left wondering why it shows up like that. Thanks!

Abhishekkochar added a commit that referenced this issue Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/pool For liquidity pool components, including homepage area/ui-ux For all UI/UX enhancement requests kind/feature New feature request needs/triage Waiting for triage to be accepted priority/important-soon Will be important soon
Projects
None yet
Development

No branches or pull requests

3 participants