Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hasAuthorsAtR field in dbMat #11

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

add hasAuthorsAtR field in dbMat #11

wants to merge 1 commit into from

Conversation

LiNk-NY
Copy link
Contributor

@LiNk-NY LiNk-NY commented Feb 10, 2023

Hi Lori, @lshep

It would be good to include the hasAuthorsAtR field in the VIEWS file.
This would help us identify more easily what packages need to use this field in the DESCRIPTION file.

https://bioconductor.org/packages/release/bioc/VIEWS
https://bioconductor.org/packages/devel/bioc/VIEWS

related to: seandavi/BiocPkgTools#65

@lshep
Copy link
Contributor

lshep commented Feb 13, 2023

we'll need to test this to make sure it works properly since if the VIEWS files does not get generated it will block updates and landing page generation on the website for packages.

@LiNk-NY LiNk-NY requested a review from lshep August 21, 2024 14:04
@lshep
Copy link
Contributor

lshep commented Aug 26, 2024

@jwokaty with the reorg of code is this run by the central builder on jetstream?

@hpages
Copy link
Contributor

hpages commented Sep 6, 2024

It is run on the central builder in the biocpush account but biocViews will need to be updated manually there.

@LiNk-NY It should be:

identical(length(field), 1L) && !is.na(field) 

rather than:

!is.na(field) && identical(length(field), 1L)

If length(field) happens to be != 1 then !is.na(field) will be a logical vector of length !=1 which will cause problems in the context of &&. By putting it after the && it will only be evaluated if length(field) is 1.

Also no need to use identical() here, length(field) == 1L is just fine and more natural.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants