Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'genome' argument to makeTxDbFromGFF() #55

Closed
hpages opened this issue Mar 15, 2023 · 3 comments
Closed

Add 'genome' argument to makeTxDbFromGFF() #55

hpages opened this issue Mar 15, 2023 · 3 comments
Assignees

Comments

@hpages
Copy link
Contributor

hpages commented Mar 15, 2023

Edit: All makeTxDb*() functions have moved to the new txdbmaker package. So I re-created this issue there and I'm closing this one.

Right now (as of GenomicFeatures 1.51.4) makeTxDbFromGFF() produces a TxDb object that has an unspecified genome by default. To change this, one needs to explicitely set the genome on the TxDb object returned by makeTxDbFromGFF(), e.g. with genome(txdb) <- "T2T-CHM13v2.0" (it's important to use the official name of the assembly otherwise the seqlevelsStyle() setter won't be able to switch the sequence naming style to UCSC or RefSeq). Alternatively one can specify the genome at creation time with makeTxDbFromGFF(..., metadata=data.frame(name="Genome", value="T2T-CHM13v2.0")) but this is admitedly poorly documented and not very convenient.

So let's add a genome argument to makeTxDbFromGFF().

@hpages hpages self-assigned this Mar 15, 2023
@PanZiwei
Copy link

Hi,
I am interested to use genomic annotation for T2T. Does Genomicfeatures support the T2T loading? If so, can you provde more hints on that?
Thank you!

> makeTxDbFromGFF(..., metadata=data.frame(name="Genome", value="T2T-CHM13v2.0"))
Error: '...' used in an incorrect context

@hpages
Copy link
Contributor Author

hpages commented Dec 12, 2023

Your question is barely related to this issue. I opened a separate issue where I answer your question. See issue #65. Please use that other issue for any follow-up. Thanks!

H.

@hpages
Copy link
Contributor Author

hpages commented Mar 23, 2024

All makeTxDb*() functions have moved to the new txdbmaker package. So I re-created this issue there and I'm closing this one.

@hpages hpages closed this as completed Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants