Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAString does not convert strings to upper case #84

Closed
stitam opened this issue Sep 27, 2022 · 1 comment
Closed

AAString does not convert strings to upper case #84

stitam opened this issue Sep 27, 2022 · 1 comment

Comments

@stitam
Copy link

stitam commented Sep 27, 2022

Hi,

I have noticed the following small inconsistency:

While DNAString automatically converts a lower case strings to upper case:

Biostrings::DNAString("atgc")
#> 4-letter DNAString object
#> seq: ATGC

Created on 2022-09-27 with reprex v2.0.2

AAString (and AAStringSet) does not:

Biostrings::AAString("mkig")
#> 4-letter AAString object
#> seq: mkig

Created on 2022-09-27 with reprex v2.0.2

The impact of this inconsistency is that some other packages seem to depend on upper case characters and may fail sporadically if I am not careful. I understand this issue can be fixed from multiple sides but I am wondering if it would be possible for AAString() and AAStringset() to enforce upper case characters, similarly to DNAString() and DNAStringSet()? Many thanks.

@ahl27
Copy link
Collaborator

ahl27 commented Mar 28, 2023

Fix for this is in PR #97

@hpages hpages closed this as completed Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants