Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Schemas contain invalid format text declaration #8

Open
AlasdairGray opened this issue Nov 15, 2019 · 2 comments
Open

JSON Schemas contain invalid format text declaration #8

AlasdairGray opened this issue Nov 15, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@AlasdairGray
Copy link
Member

Generated JSON Schemas contain "format": "text" declarations. text is not a valid value for the format declaration and causes problems for some libraries processing the JSON Schemas.

It looks like the offending code is
https://github.com/HW-SWeL/BioschemasMarkupGenerator/blob/4895fe1ca4c68b375b3d30ff8cb95a932fa98243/Scripting-Tool/generateBioschemasFiles.py#L50
@AlasdairGray AlasdairGray added the bug Something isn't working label Nov 15, 2019
@AlasdairGray
Copy link
Member Author

@Petrosss can you try removing line 50 and see whether the generator tool will still work with the resulting schemas?

@AlasdairGray
Copy link
Member Author

This was a problem for the libraries being explored for the BisochemasValdiator. That tool has now moved on to use a ShEx based validation approach and this does not seem to be causing an issue for anything else.

It looks like "format": "text" is not a defined type that would be supported https://json-schema.org/understanding-json-schema/reference/string.html#string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlasdairGray