Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjust the padding size on the quiz screen #381

Open
phoebe-buffay opened this issue Sep 10, 2024 · 9 comments
Open

feat: Adjust the padding size on the quiz screen #381

phoebe-buffay opened this issue Sep 10, 2024 · 9 comments

Comments

@phoebe-buffay
Copy link
Collaborator

What feature?

When user starts quiz from this page
Screenshot 2024-09-10 at 17 33 00
we see the padding size as 15

When user is on the first quiz question page, the padding is 34
Screenshot 2024-09-10 at 17 33 17

Please, adjust the size of the paddings to the one size

Add screenshots

No response

@phoebe-buffay phoebe-buffay added the enhancement New feature or request label Sep 10, 2024
@phoebe-buffay phoebe-buffay added this to the bebalance-release-4 milestone Sep 10, 2024
@KeidsID KeidsID self-assigned this Sep 18, 2024
@KeidsID KeidsID moved this to In Progress in bsa-2024-bebalance Sep 18, 2024
@KeidsID KeidsID added frontend adjustment and removed enhancement New feature or request labels Sep 18, 2024
@fshabanov fshabanov removed their assignment Sep 18, 2024
@KeidsID KeidsID moved this from In Progress to In Code Review in bsa-2024-bebalance Sep 19, 2024
@KeidsID KeidsID moved this from In Code Review to To Test in bsa-2024-bebalance Sep 19, 2024
@phoebe-buffay
Copy link
Collaborator Author

Please, watch a video, and observe all the pages start from the Quiz start page - how paddings are look on each screen with questions. And adjust all of them to the one view. For now they differ between each other. They should be the same.
https://github.com/user-attachments/assets/162641c0-fa51-4ec3-be22-56f0f10752f8

@KeidsID
Copy link
Collaborator

KeidsID commented Sep 20, 2024

I think you test it when the changes aren't deployed yet (PR are merged, but not released yet). Could you try to test it again?

Screenshot (415)
Screenshot (416)

@KeidsID KeidsID moved this from Todo to To Test in bsa-2024-bebalance Sep 20, 2024
@phoebe-buffay phoebe-buffay self-assigned this Sep 20, 2024
@phoebe-buffay
Copy link
Collaborator Author

quiz questions 3rd and 7th have bad paddings.
https://github.com/user-attachments/assets/43837cbf-551b-423c-80c1-ca73ba9296b7

@KeidsID
Copy link
Collaborator

KeidsID commented Sep 20, 2024

@phoebe-buffay
That's because the quiz content requires more space than the screen height, so the container extends downward. If scrolled down, the padding will be visible with the same size as the top padding.

I am more concerned about the UX, it would be better if the scroll reset to the top for each question change. So what do you think? Should we make a new ticket for it?

Recording.2024-09-20.220920.mp4

@phoebe-buffay
Copy link
Collaborator Author

@fshabanov please advise

@phoebe-buffay
Copy link
Collaborator Author

@KeidsID please consider the @fshabanov answer
"The content shouldn't affect the padding. The padding and the content are independent of each other. If the content is large, we will have a scrollable view, that's it"

@KeidsID
Copy link
Collaborator

KeidsID commented Sep 24, 2024

I agree that padding and content are independent, and the content shouldn't affect the padding. The padding update has already been applied as per the ticket requirements. If you have any other feedback or concerns, please feel free to share, but from my side, the ticket is ready to be marked as done.

@phoebe-buffay
Copy link
Collaborator Author

I can't consider ticket as done, as i still have issues with paddings. When all the paddings look correct, so then i will be able to close the ticket. For now please work on the problem. As @fshabanov has mentioned, you can add scroll to look paddings the same

@phoebe-buffay
Copy link
Collaborator Author

if you plan to implement this change in the scope of a separate ticket, closing this one, notify me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants