Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Dockerfile #175

Closed
wants to merge 1 commit into from
Closed

Adds Dockerfile #175

wants to merge 1 commit into from

Conversation

ivotron
Copy link

@ivotron ivotron commented Aug 4, 2017

Usage:

cd enos
docker built -t enos .
docker --rm \
  -e OS_AUTH_URL=<url> \
  -e OS_TENANT_ID=<user-id> \
  -e OS_TENANT_NAME=<project-id> \
  -e OS_PROJECT_NAME=<project-id> \
  -e OS_USERNAME=<user> \
  -e OS_PASSWORD=`cat os_password_file` \
  -v `pwd`:/experiment \
  --workdir=/experiment \
  enos up

fixes #173

msimonin
msimonin requested changes Aug 4, 2017
View reviewed changes
Copy link
Contributor

@msimonin msimonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ivotron
Some comments inline. An entry in the documentation needs to be added.

Dockerfile Outdated
@@ -0,0 +1,6 @@
FROM python:2.7

RUN pip install enos && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enos should be installed from the corresponding git revision.
This could be something like :

COPY . /tmp/enos
WORKDIR /tmp/enos
RUN pip install .

@ivotron
Copy link
Author

ivotron commented Aug 4, 2017 •
edited
Loading

@msimonin thanks for the feedback. I had an issue with dateutil. Seems that blazarclient is pulling version 2.6 (just a guess). I tried with python-dateutil>=2.2 and all seemed to work fine.

Also, can you please point me to where in the docs I should add an entry describing how to use the image?

msimonin
msimonin reviewed Aug 4, 2017
View reviewed changes
setup.py
@@ -35,7 +35,7 @@ def read(fname):
'influxdb==4.0.0',
'docopt>=0.6.2,<0.7.0',
'httplib2==0.9.2',
'python-dateutil==2.2',
'python-dateutil>=2.2',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1

@msimonin
Copy link
Contributor

msimonin commented Aug 4, 2017

A new chapter (a new file) could be named Enos and docker and a link to it could be added in the getting-started page (docs/installation.rst).
In this part we could learn how to build and use the image and some general information on how to share variables and file (e.g reservation.yml) between the host and the container.
As building the docker image will probably be in our release pipeline, we'll adapt later this part to indicate how to get the "official" Enos docker image.

Note that this change will probably be backported on stable/ocata branch so that enos-2.y.z will be available through docker as well.

@msimonin
Copy link
Contributor

ping @ivotron ?

@msimonin
Copy link
Contributor

@ivotron I'm closing this,
Feel free to come back to this anytime if you still needs it. You'll maybe interested in https://github.com/BeyondTheClouds/enoslib - there is (an undocumented) support for chameleon cloud.
thanks !

@msimonin msimonin closed this Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimonin msimonin msimonin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Dockerfile for containerizing enos
2 participants
@ivotron @msimonin