Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of https://betamasaheft.eu/additions page #26

Open
DrRataplan opened this issue Dec 10, 2024 · 4 comments
Open

Status of https://betamasaheft.eu/additions page #26

DrRataplan opened this issue Dec 10, 2024 · 4 comments

Comments

@DrRataplan
Copy link
Contributor

Hey!

While refactoring things to make the Betamasaheft app work in Exist db 6 (and higher) I ran into some slow and sometimes failing E2E tests in the additions page. This page is technically still alive, it's mentioned in the controller.xql routing, but the sole entrypoint in the app (

See also <a href="https://betamasaheft.eu/additions">the list of documents contained in the additiones</a> in the manuscripts described by the Beta maṣāḥǝft project .
) is not in use since the menu item it's an explanation for is commented out (
removing link to resource which is currently not maintained
)

@eu-genia Is this whole page unused? If so, I'll remove the Cypress tests for it.

Thanks!

@eu-genia
Copy link
Contributor

eu-genia commented Dec 11, 2024

The page should be used but is part of our loading times issue set
BetaMasaheft/Documentation#1944
https://github.com/BetaMasaheft/betmas-e2e/issues/5

Same for many filtered searches.
Still the link is active from resources navigation menu and from the homepage

image

image

  • and right now I could open the page.
    image

We count very much on your help that the loading times for this and other similar pages - as well as the other

@eu-genia
Copy link
Contributor

eu-genia commented Dec 11, 2024

As you see from past issues here the lists (additions, decorations) all got timed out, I had to limit the hits (resources.xqm line 877 in 77129b8 ) to get the list to load, but probably there is a better way to query data

@DrRataplan
Copy link
Contributor Author

Ah, that makes a lot of sense! I'll see if I can speed the up a bit! Thanks for the explanation!

@eu-genia
Copy link
Contributor

eu-genia commented Dec 11, 2024

the link removed in nav.xqm is not to additions but as you can see in the code to
href="/documentcorpora.html - this is a resource I am currently not maintaining

 <!-- 
                      removing link to resource which is currently not maintained
                      <a
                            class="w3-bar-item w3-button w3-margin w3-padding w3-round w3-border w3-border-red explain"
                            data-value="documentary"
                            href="/documentcorpora.html">Documentary corpora</a>-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants