Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Issue #58

Open
ghost opened this issue May 23, 2017 · 3 comments
Open

Memory Issue #58

ghost opened this issue May 23, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented May 23, 2017

I am finding an issue where tabs that are closed do not clean up their memory.

This happened when transitioning from 1.1.2p15 to 1.1.2p16.

If I comment out the following line of code that was added for 1.1.2p16, I no longer have memory issues.
From AbstractTabLayoutManagerPane.java:

public void controllerChanged( TabPane pane, DockController controller ){
	// useSmallMinimumSize.setProperties( controller );
}

This only seems to happen when using the KEY_ECLIPSE_THEME

control.setTheme(ThemeMap.KEY_ECLIPSE_THEME);

Heap Walker Capture Attached
memory

@Benoker
Copy link
Owner

Benoker commented May 23, 2017

Thanks for reporting this issue, and for the analysis as well! This makes my work much easier 👍

I'll try to reproduce and fix it with the next version (I should be able to work on this during the upcoming weekend).

@Benoker
Copy link
Owner

Benoker commented Jun 4, 2017

Turns out the issue is just a "listener" which is not removed properly. Is fixed with the next version.

@ghost
Copy link
Author

ghost commented Jun 7, 2017

Excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant