Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Tip 1 to "Decide if deep learning may be appropriate for your problem" #228

Closed
ejfertig opened this issue Sep 29, 2020 · 11 comments · Fixed by #241
Closed

Rename Tip 1 to "Decide if deep learning may be appropriate for your problem" #228

ejfertig opened this issue Sep 29, 2020 · 11 comments · Fixed by #241

Comments

@ejfertig
Copy link
Collaborator

I find the comment "Those developing deep learning models should select datasets that are relevant to the problem at hand; non-salient data can hamper performance or lead to spurious conclusions." unclear. How can someone determine if they have the right dataset? Does this mean in terms of sample size or something else? Some clear examples would help.

@ejfertig
Copy link
Collaborator Author

Also, as a further comment to this -- there appears to be some overlap between the dataset selection w/in tip 1 and the tip 4 know your data. Would help to streamline and clarify the differences in the points on data selection in these two tips.

@cgreene
Copy link
Collaborator

cgreene commented Sep 29, 2020

This is a good point - particularly as it relates to transfer learning and/or domain adaptation.

@Benjamin-Lee
Copy link
Owner

@cgreene what do you think about moving the content that overlaps in tip 1 to each respective tip (overfitting and know your data, etc) and then subbing in the "decide if DL is right for your problem" tip you proposed here: #225 (review)

@cgreene
Copy link
Collaborator

cgreene commented Oct 5, 2020

Yea - I think I really like this. Tip 1 could be "Decide if deep learning may be appropriate for your problem" and then the rest of the text moves. That tip could contain the current sentiment of tip 1. 👍

@ejfertig
Copy link
Collaborator Author

ejfertig commented Oct 5, 2020

Agreed. I think it would be really helpful to define different flavors of deep learning here and how you can select between models for specific problems. How can you use DL in a supervised context? Unsupervised? When would DL be the best choice?

@Benjamin-Lee
Copy link
Owner

@cgreene Do you think you could work together with me to get the rewrite done by the end of the week, which is the original deadline for freezing changes (#226)? We could also push the deadline back, though I hate to prolong things even more.

Either way, I can make a PR moving the content and renaming the first tip to get started on this process. @pstew, @agitter, and @rasbt, what do you think of this idea?

@Benjamin-Lee Benjamin-Lee changed the title Suggested edit within tip 1 Rename Tip 1 to "Decide if deep learning may be appropriate for your problem" Oct 5, 2020
@ejfertig
Copy link
Collaborator Author

ejfertig commented Oct 5, 2020

I can help with editing and a view fOr clarity from the non DL perspective if it’s helpful.

@agitter
Copy link
Collaborator

agitter commented Oct 5, 2020

what do you think of this idea?

I have other deadlines this week so I'm not sure I'll be able to spend much time here. Please feel free to made edits as you'd like.

@Benjamin-Lee
Copy link
Owner

@agitter, understood. Would pushing back another week be better for your schedule? I'm not trying to rush things, just to keep up the momentum.

@agitter
Copy link
Collaborator

agitter commented Oct 5, 2020

It may not make a difference. You have some good momentum now, so I'd say keep it going.

@rasbt
Copy link
Collaborator

rasbt commented Oct 5, 2020

I am in the same boat as @agitter (and there are midterms this week). I would be happy to & able to review the paper at / towards the end of the week, or by next week. By "reviewing" I mean making a full pass and provide feedback or suggest some final edits.

@Benjamin-Lee Benjamin-Lee mentioned this issue Oct 7, 2020
1 task
@Benjamin-Lee Benjamin-Lee linked a pull request Oct 11, 2020 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants