Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requested merge style to CONTRIBUTING.md #198

Open
michaelmhoffman opened this issue Aug 2, 2019 · 2 comments
Open

Add requested merge style to CONTRIBUTING.md #198

michaelmhoffman opened this issue Aug 2, 2019 · 2 comments
Assignees
Labels
meta Issues about the Deep Rules repository

Comments

@michaelmhoffman
Copy link
Collaborator

I would merge #196 but I do not know whether merge commit, squash and merge, or rebase and merge are preferred. Please specify in CONTRIBUTING.md.

@agitter
Copy link
Collaborator

agitter commented Aug 2, 2019

@Benjamin-Lee you've been using merge commits in this repository, right?

Regardless of what we specify as the preferred merged style for general updates, we need to specify that rootstock updates are made via merge commits.

@dhimmel
Copy link
Collaborator

dhimmel commented Aug 2, 2019

Personally, I haven't found much user for rebase commits, since usually I'd like to make the merging explicit (since master branch CI will only run on the tip rebase commit IIRC). As @agitter mentioned, merge should be used for manubot updates pulled from rootstock. Otherwise, it's up to project maintainers. I usually squash unless there is some reason to keep the composite commits (like multiple authors or to break up a large changeset).

@Benjamin-Lee Benjamin-Lee added the meta Issues about the Deep Rules repository label Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues about the Deep Rules repository
Projects
None yet
Development

No branches or pull requests

4 participants