Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to SymfonyExtension and Symfony 4 #134

Open
sroze opened this issue Nov 23, 2017 · 6 comments
Open

Rename to SymfonyExtension and Symfony 4 #134

sroze opened this issue Nov 23, 2017 · 6 comments

Comments

@sroze
Copy link
Contributor

sroze commented Nov 23, 2017

Instead of creating another one, I propose:

  1. To rename the extension (and all the class namespaces) to "SymfonyExtension" instead of "Symfony2Extension"
  2. Release a version 3.0.0 with these name changes, which supports Symfony 3.4+
  3. Support autowiring from version 3.0.0

WDYT ? :)

@jon-acker
Copy link

What was the rational behind re-writing it then?

@ciaranmcnulty
Copy link
Contributor

What do you think about splitting the Mink driver integration from the service container integration?

Probably the new versions can use the existing PSR-11 mechanism and simply hook in the container

@stof
Copy link
Member

stof commented Nov 23, 2017

if we rename the package, change the namespace and rewrite a big part of the code (to benefit from both Symfony new features but also Behat 3.4+ ones), we might a well consider it as a new extension though

@DavidGarciaCat
Copy link

As @sroze suggested, I see the benefit of SymfonyExtension, but as @stof has pointed, this could imply a new extension, especially in order to keep BC for existing projects. May I suggest a new repository that could be a clone of this one + the NameSpace changes?

@DavidGarciaCat
Copy link

Even if the extension is not renamed, IMO the Symfony 4 support should be applied, in order to be used on new projects. It's really frustrating when we can see that BeHat is already implementing a Symfony Recipe however I cannot install it to test Symfony 4 + BeHat

@sroze
Copy link
Contributor Author

sroze commented Apr 8, 2018

This will help with Symfony 4.1: #139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants