RCD, Airlock QoL

[Tsar-Salat]

Ports:

• RCD Additions + Cyborg RCD Upgrades tgstation/tgstation#52018
• The Cycling 2.0, Airlocks can now be built in game to cycle and named tgstation/tgstation#61226

About The Pull Request

Airlock's are now possible to build in-game. (or atleast cyclelinks are).

RCD's can now print windoors, 1-dir windows, named airlocks, cyclelinked airlocks, and furnishings.
How RCD's handled matter was also significantly refactored.

As the plumberator is a subtype of RCDs, those received small cleanup, but nothing noteworthy or playerfacing.

TODO:

• No conflicts
• Radial sprites all appear
• Can insert mats into RCD
• Can insert compressed matter into RCD
• Can name & link airlocks
• Can place windows
• Can place furnishings

Why It's Good For The Game

Theres no real reason not to have furnishings and directional windows on the RCD.
Plus the addition of making airlocks in game will assist greatly for those making custom shuttles.

Mat insertion is literally just a bunch of if statements, we should just be assigning a value to the mats able to be inserted, and checking for that value when inserting any mat. Then it's simple as adding one line of code under whatever /obj/item/stack/sheet we want to add in the future

Testing Photographs and Procedure

Changelog

🆑 rkz, AlinaStarkova
tweak: You can now set an Airlocks name and cycle ID in the RCD airlock settings menu, or by clicking on an airlock control board and making an airlock manually, this allows you to make airlocks that can cycle with each other. examine an airlock to see what, if any, ID they are set to cycle on (linear 1x3 airlocks to space currently do not use cycleIDs)
add: The RCD's functionality for directional windows has been enabled.
add: Cyborgs can now install RCD upgrades, with the notable exception of silo link upgrade
add: The RCD's functionality for windowed doors has been enabled.
add: The RCD furnishing upgrade may now be installed
/:cl:

[CydiaLamiales]

Engineborg buffs, pogu

[PestoVerde322]

do the "expansion" tag exist for the CL?

[itsmeow]

No they do not, remove them

[Tsar-Salat]

changed to tweak

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Tsar-Salat]

I am planning on finishing this, im just atomizing what I can so this is more legible and less of a mess

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Tsar-Salat]

I broke radial sprites for the new upgrade at some point, gotta fix em

[Tsar-Salat]

Alright, Furnishing labels now use Bee chair/table/stool sprites instead of TG and actually appear. Yay.

This is now ready.

[PowerfulBacon]

Kinda cool, I am still strongly against the RCD but at the same time its kind of needed for construction because of how long and convuluded contruction has been made.
If these are getting constantly used to build annoying nukie holdouts with glass doors on nukie rounds, then they will definitely be getting a nerf.

[Tsar-Salat]

Kinda cool, I am still strongly against the RCD but at the same time its kind of needed for construction because of how long and convuluded contruction has been made.

Mhm, TG made it more expensive to use overall I believe, but cheaper if you are rebuilding or deconstructing roundstart structures, which may be a possible design avenue to explore in the future.

I like the idea of an RCD as a utility, not a replace-all construction type tool.

At the very least, it being on shuttles makes more sense now that you can make cyclelinks ingame.