Adds Combat mode, rclick functionality

[Tsar-Salat]

About The Pull Request

This adds right-click functionality through the addition of the combat mode system.

Changes are as listed:

Major Codebase changes

• Disarm and Grab Intents have been removed.
• Diametric intents (harm/help) are not combat mode. Toggled by F or 4.
• Context menu now appears on shift+rclick (like examine)
• Disarm functionality has now been moved to rclick, whether CM is active or not
• Grabbing has been centralized in its hotkey ctrl-click

Functional Item changes

• Ninja Dash now activates via right-click
• M90 grenade launcher activates through right click rather than toggle
• Health analyzer now scans health with left click, chemicals with right click
• Jumpsuits change suit sensors through right-click
• Airlocks are now welded through rightclick
• Reagent splashing is done through right click
• RCDs deconstruct through rclick
• Syringes now lclick to inject, rclick to draw
• washingmachines now use rclick to start
• stack splitting now uses rclick
• hookshotguns use rclick instead of toggle
• deconstructing windows, tables, chairs is done through rclick with appropriate tools
• secure lockers are now (un)locked through rclick
• gas canisters are repaired on lclick and deconstructed on rclick
• right clicking a reagent container will now set it to its previous transfer amount
• Screwdrivers can now be put in autolathes through lclick, maintenance through rclick
• girders can be built by rclicking a turf with a sheet of iron (allowing building multiple at the same time)
• Most previously rotatable structures or machines can now be rotated through mouseclick. Left for Counterclockwise, right for clockwise.
• closet wrench actions moved to rclick
• chemistry machines use rclick to add/remove their beakers
• Kinetic Crusher projectiles are now fired on rclick
• ID Painter now lets your remove IDs/PDA through rclick

Ports:

• Replaces intents with combat mode tgstation/tgstation#56601
• Energy katana now uses right click to teleport instead of toggling tgstation/tgstation#56636
• M90 changes tgstation/tgstation#56667
• Toggle suit sensors is now bound to right click tgstation/tgstation#56699
• Add locking into portals with right click on hand tele, refactor hand tele code, add pre_attack_secondary tgstation/tgstation#56700
• Chemical scan is now on right click, removes it as a toggle tgstation/tgstation#56779
• Fix jumpsuit right click not opening suit sensors, adds attack_hand_secondary tgstation/tgstation#56781
• Right clicking on airlocks now tries to weld them tgstation/tgstation#56811
• Generalize splashing reagent containers code, put it on right click tgstation/tgstation#56813
• Refactor can_inject, and introduce try_inject tgstation/tgstation#56816
• right clicking on a ranged attack now calls afterattack when it's supposed to tgstation/tgstation#56829
• Converts all uses of modifiers to lazy access to avoid memes in future tgstation/tgstation#56846
• RCDs now use right click to deconstruct tgstation/tgstation#56864
• Syringe toggle has been replaced with left-click to inject, right-click to draw. You can also now change transfer amount. tgstation/tgstation#56865
• RangedAttack now takes modifiers. tgstation/tgstation#57214
• Refactors /mob/living/CtrlClick(mob/user) and fixes pulling issues. tgstation/tgstation#57617
• Washing machine now uses right click to start a wash cycle tgstation/tgstation#57788
• Stack splitting now uses right click tgstation/tgstation#57837
• Adds RangedRightClickOn to Mobs tgstation/tgstation#57841
• Adds right-click support to AIs/Cyborgs tgstation/tgstation#57881
• Clicking floor tiles closes airlocks tgstation/tgstation#58124
• makes the hook shotgun work on right click, adds new icons for it tgstation/tgstation#58270
• Changes reinforced window deconstruction to right click tgstation/tgstation#58523
• Moves secure closet locking to Right click tgstation/tgstation#58774
• Replace Maint. Drone machinery whitelist with last touched check & other tweaks tgstation/tgstation#58802
• Allows canister repairs and adds right click tool acts tgstation/tgstation#58830
• Right-clicking on reagent containers picks previous reagent transfer amount tgstation/tgstation#59508
• Modifies right click logic so that it is not the same priority as modifier keys. tgstation/tgstation#59656
• Fix incorrect return for closet attack_hand_secondary causing lockers to have their locks toggled twice. tgstation/tgstation#59814
• Renames RemoveComponent, fixes a dumb runtime in Destroy tgstation/tgstation#60653
• Fixes monkey being unable to access right click functions on many objects. tgstation/tgstation#60990
• Autolathe fixes: screwdrivers are recyclable, no inserting mats with an open maint panel tgstation/tgstation#61275
• More girder building tgstation/tgstation#61795
• Fixes some issues and an exploit with abandoned crates. tgstation/tgstation#62949
• Moves deconstructing beds and chairs to right click tgstation/tgstation#63038
• Rotation component refactor and improvements tgstation/tgstation#64441
• Fixing a number of issues with burial mounds and abandoned crates. tgstation/tgstation#64482
• Wrench interactions with closets migrated to wrench_act_secondary tgstation/tgstation#64724
• Change hydroponics tray and chem dispenser AltClick behavior to be used by RMB  tgstation/tgstation#64939
• Puts the kinetic crusher's projectile firing on rmb tgstation/tgstation#64964
• Fixes Abandoned Crates exploding on right click + Code improvements. tgstation/tgstation#65353
• Moves more chem machine eject beaker shortcuts to right click, allows silicons to use shortcut tgstation/tgstation#65978
• You can take out PDA/ID from trimmer with right click tgstation/tgstation#66038
• Small refactor to how analyzer's last atmos gasmix data is made tgstation/tgstation#66928
• Fixes seeing rotation failed message ballons at distance tgstation/tgstation#72463
• Implements functionality for variable weapon attack and secondary weapon attack speeds. tgstation/tgstation#72959
• Removes amount_list_postion from reagent containers, adds related unit test. tgstation/tgstation#76057

Why It's Good For The Game

Intents are by-and-large not a very well written system. The "grab" intent, for instance, has had a hotkey for years on ctrl-click.

The large goal of this PR is to address two fundamental issues:

1. The current intent check system, which almost entirely relies on if a character is or is not on help or harm mode, to determine that players intention.
2. The clunkiness of actual systems that DO fully utilize the intent system

For the first issue, nearly all of our intent checks in the codebase are just diametric checks for if a player is in harm or help mode. Grab is only checked when checking grab_state, which is attached to attack_hand, otherwise you can basically forget about the intent and just use the ctrl hotkey.
Disarm is in an even worse boat, its basically Harm Jr. in that players in combat will primarily be on harm while in combat and be spam-switching between the two only for the purpose of trying to stun them on a wall, table, or mob.

For the second issue, the most notable use of intents is martial arts. This is not to the boon of martial arts either, as the combination of moves that you have to do mid-combat is not very well done.

Allowing players to free up their mouse instead of the specific intents gives coders a lot more room and buttons to work with, and allow simplification for needlessly complex tasks like martial arts or construction.

Testing Photographs and Procedure

Screenshots&Videos

rclick welding

dreamseeker_3glRJS1Dp3.mp4

lclick/rclick syringes

dreamseeker_NzvFfxDE1k.mp4

grab states

dreamseeker_zvpHi0bMQQ.mp4

RCD rclick deconstruction

dreamseeker_Nez9ejXPHj.mp4

generic structure deconstruction

dreamseeker_uBsH8AheX2.mp4

CW/CCW mouse rotation

dreamseeker_LJmxLX3m8t.mp4

rclick girder construction

dreamseeker_8bMhahRAPx.mp4

Changelog

🆑 rkz, Qustinnus, Mothblocks, TJatPBnJ, IndieanaJones, KathyRyals, Arkatos, norill, Fikou, dragomagol, SgtHunk, JJRCop, ninjanomnom, cacogen, Timberpoes, LemonInTheDark, Ghommie, Sealed101, Ghilker, TheBonded, Timothymtorres, CameronWoof, ArcaneDefence, BurgerLUA, OneAsianTortoise, vincentiusvin, itseasytosee, AnturK
add: Adds combat mode
refactor: refactored syringe code to use flags
tweak: clicking on the turf of a airlock while combat mode is off will now close the airlock. No more pixel hunting!
balance: buffs to hook shotgun in addition to rclick functionality
code: renames RemoveComponent, component destroy will no longer runtime when parent is null
refactor: refactored simple rotation component
fix: fixed abandoned crates to not try to kill you if you perform actions on them AFTER they are unlocked
code: introduced variable weapon attack speed. No weapon utilizes this yet but admins can now varedit items to attack faster/slower.
code: unit tests reagent container transfer amounts
/:cl:

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[llol111]

So the day has come
its all over
Annihilation awaits

[Geatish]

Rip to all the screwdrivers that will be consumed by the autolate

[EvilDragonfiend]

eh is it really golden? but well I guess any maint can give one. prolly deserving when it's a big port.

[Archanial]

I like it, good pr ‼️

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Rukofamicom]

eh is it really golden?

According to the tag yes:

This was a really high-effort port that also has a major impact on the game.

[PowerfulBacon]

I am running this locally and the hotkeys F/4 don't show up in the preferences menu and don't work. Do the hotkeys for this action actually exist?

The context menu is also enabled by default, and to turn it off you have to first press the shift key.

Holding shift also doesn't show the examine magnifying glass like other servers have.