Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad Error Handling of Missing rpPath and bpPath in exact export target #301

Open
Nusiq opened this issue Dec 15, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Nusiq
Copy link
Member

Nusiq commented Dec 15, 2024

The exact export target shouldn't insert the default value of an empty string into bpPath and rpPath.

With this behavior, the only thing that prevents Regolith from deleting entire project is the safety mechanism for file deletion. The safety mechanism is also the part of the code that reports the problem, which is misleading because the source of the problem is the unspecified export path.

Regolith should ask the user to provide a valid path when the bpPath and rpPath aren't specified or are empty strings.

The only case that should allow omitting specifying the bpPath and rpPath is when the project itself doesn't have RP or BP. Alternatively, we could treat the empty path string as no export. This way using exact export target without bpPath and rpPath would be equivalent to using the none export target.

@Nusiq Nusiq added the bug Something isn't working label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant