Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Documentation #7

Open
eibar-flores opened this issue Oct 30, 2024 · 2 comments
Open

Code Documentation #7

eibar-flores opened this issue Oct 30, 2024 · 2 comments
Assignees

Comments

@eibar-flores
Copy link

Document and revise the code to render it more readable.

  • Add docstrings to functions.
  • Revise naming conventions for variables. Long descriptive names are preferred over abbreviations. See here for best practices.
  • Maximize compliance with Julia Style guide
@moyner
Copy link
Member

moyner commented Nov 8, 2024

We could add Julia formatter to automatically make the code uniform

@eibar-flores
Copy link
Author

I went through the documentation and again, it looks neat! Here is some points I gathered while exploring it:

Plans for populating missing entries

  • We should plan what to add in the missing links: Getting Started button, the four feature banners (accurate an open, ...)
  • We should also plan populating the NavBar, specially the introduction and manual.

A Typo:
The Cycling example is titled "Cycling a battery 40 times" but the [input json] instructs the simulation to cycle the cell only 3 times, see ./Control/numberOfCycles = 3. The example title should be corrected.

Consolidate example style
The cycling example is concise and clear, it probably has the lowest entry barrier for newcomers. However, the Battery example uses a hook API that makes the example harder to follow and understand, specially if these hooks have not been explained. I would suggest to simplify the Battery example, or remove it entirely if it overlaps with the well-described cycling example.

Additional examples

  • Validation: super valuable. How to compare a simulation Voltage curve with an experimental one
  • Degradation: How to run multiple cycles with the SEI model, and how to visualize SEI parameters (e.g. SEI thickness, SEI resistance).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants