Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move check of static collision from Visitors to DynamicCollisionDetectionStrategy #14

Open
Bartanakin opened this issue Oct 30, 2024 · 0 comments
Open

Move check of static collision from Visitors to DynamicCollisionDetectionStrategy #14

Bartanakin opened this issue Oct 30, 2024 · 0 comments
Labels
Easy Scale of knowledge of the project requirement Quick Scale of workload requirement

Comments

@Bartanakin
Copy link
Owner

In every class implementing CheckCollisionVisitorInterface in the method checkDynamicCollision there is always a check of static collision using the checkStaticCollision method. It is better to move the checkout out of the Visitors to the DynamicCollisionDetectionStrategy.

The lack of a static collision is a precondition to start checking the continuous collision.
@Bartanakin Bartanakin added Easy Scale of knowledge of the project requirement Quick Scale of workload requirement labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Scale of knowledge of the project requirement Quick Scale of workload requirement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bartanakin