From 5efd03ee5fe5096e000f1b8ae64b68f18f0a7d54 Mon Sep 17 00:00:00 2001
From: barts <b.steensma@fleetcleaner.com>
Date: Mon, 29 Jan 2024 21:55:11 +0100
Subject: [PATCH] refactor: build-ffmpeg

---
 README.md            |  3 ++
 scripts/build-ffmpeg | 85 +++++++-------------------------------------
 2 files changed, 15 insertions(+), 73 deletions(-)

diff --git a/README.md b/README.md
index 27ddf8e..512e44c 100644
--- a/README.md
+++ b/README.md
@@ -424,6 +424,9 @@ more information.
       these can be linked statically as well. Do this only for the dependencies
       that are included in the ffmpeg docs.
 
+- [ ] Use ffmpeg 6.0, that is tested by Qt. If not possible, fix the version
+      instead of using the latest version.
+
 - [ ] Does it also work when the user has an older version of libc installed
       than ubuntu 22.04 has?
 
diff --git a/scripts/build-ffmpeg b/scripts/build-ffmpeg
index e7d6b4f..12d2f37 100755
--- a/scripts/build-ffmpeg
+++ b/scripts/build-ffmpeg
@@ -61,34 +61,6 @@ install_dependencies() {
     "${this_dir}/helpers/${manager}/install-ffmpeg-deps"
 }
 
-build_libdrm() {
-    echo "Building libdrm"
-    # "$this_dir/build-libdrm" -s "$source_dir/libdrm"
-
-    if command -v apt-get &>/dev/null; then
-        sudo apt -y install libdrm-dev || true
-    elif command -v pacman &>/dev/null; then
-        sudo pacman -S --noconfirm libdrm || true
-    else
-        echo "No supported package manager found"
-        exit 1
-    fi
-}
-
-build_libva() {
-    echo "Building libva"
-    # "$this_dir/build-libva" -s "$source_dir/libva"
-
-    if command -v apt-get &>/dev/null; then
-        sudo apt -y install libva-dev || true
-    elif command -v pacman &>/dev/null; then
-        sudo pacman -S --noconfirm libva || true
-    else
-        echo "No supported package manager found"
-        exit 1
-    fi
-}
-
 compile_libaom() {
     echo "Compiling libaom"
     cd "$source_dir" &&
@@ -122,49 +94,16 @@ compile_libvmaf() {
         ninja install
 }
 
-compile_ffmpeg-static() {
-    echo "Compiling ffmpeg"
-    cd "$source_dir" &&
-        wget -O ffmpeg-snapshot.tar.bz2 https://ffmpeg.org/releases/ffmpeg-snapshot.tar.bz2 &&
-        tar xjvf ffmpeg-snapshot.tar.bz2 &&
-        cd ffmpeg &&
-        PATH="$bin_dir:$PATH" PKG_CONFIG_PATH="$install_dir/lib/pkgconfig" ./configure \
-            --pkg-config-flags="--static" \
-            --prefix="$install_dir" \
-            --extra-cflags="-I$install_dir/include" \
-            --extra-ldflags="-L$install_dir/lib" \
-            --extra-libs="-lpthread -lm" \
-            --ld="g++" \
-            --bindir="$bin_dir" \
-            --enable-gpl \
-            --enable-gnutls \
-            --enable-libaom \
-            --enable-libass \
-            --enable-libfdk-aac \
-            --enable-libfreetype \
-            --enable-libmp3lame \
-            --enable-libopus \
-            --enable-libsvtav1 \
-            --enable-libdav1d \
-            --enable-libvorbis \
-            --enable-libvpx \
-            --enable-libx264 \
-            --enable-libx265 \
-            --enable-nonfree &&
-        PATH="$bin_dir:$PATH" make -j"$(nproc)" &&
-        make install &&
-        hash -r
-}
-
-compile_ffmpeg-shared() {
-    echo "Compiling ffmpeg"
+compile_ffmpeg() {
+    local file unpack_dir
+    file="ffmpeg-snapshot.tar.bz2"
+    unpack_dir="ffmpeg"
     cd "$source_dir" &&
-        wget -O ffmpeg-snapshot.tar.bz2 https://ffmpeg.org/releases/ffmpeg-snapshot.tar.bz2 &&
-        tar xjvf ffmpeg-snapshot.tar.bz2 &&
-        cd ffmpeg &&
+        wget -O "$file" https://ffmpeg.org/releases/"$file" &&
+        tar xjvf "$file" && 
+        cd "$unpack_dir" &&
         PATH="$bin_dir:$PATH" PKG_CONFIG_PATH="$install_dir/lib/pkgconfig" ./configure \
-            --disable-static \
-            --enable-shared \
+            $@ \
             --prefix="$install_dir" \
             --extra-cflags="-I$install_dir/include" \
             --extra-ldflags="-L$install_dir/lib" \
@@ -197,16 +136,16 @@ rm -rf "$source_dir" || true
 rm -rf "$install_dir" || true
 mkdir -p "$source_dir" "$bin_dir"
 install_dependencies
-build_libdrm
-build_libva
 compile_libaom
 compile_libsvtav1
 compile_libvmaf
 
 if [[ "$static" == true ]]; then
-    compile_ffmpeg-static
+    echo "Building ffmpeg static"
+    compile_ffmpeg --pkg-config-flags="--static"
 elif [[ "$shared" == true ]]; then
-    compile_ffmpeg-shared
+    echo "Building ffmpeg shared"
+    compile_ffmpeg --disable-static --enable-shared --pkg-config-flags="--shared"
 fi
 
 cd "$dir"