Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CountingBloomFilterRedis#remove() destroying the Redis Pool #43

Open
edrabc opened this issue Jan 25, 2017 · 1 comment
Open

CountingBloomFilterRedis#remove() destroying the Redis Pool #43

edrabc opened this issue Jan 25, 2017 · 1 comment

Comments

@edrabc
Copy link

edrabc commented Jan 25, 2017

The Redis Pool could be shared between several BloomFilter instances. If one of the filters is removed filter.remove(), the Redis Pool is destroyed. This makes the rest of active filter instances unusable:

@Override
public void remove() {
    clear();
    pool.safelyDo(jedis -> jedis.del(config().name()));
    pool.destroy();
}
@bfelaco
Copy link

bfelaco commented Feb 3, 2017

👍 I'd submit a pull request to remove this line but I have no idea why it's there and what else it could impact and if other changes are required to compensate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants