Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added NumbersClient class #16

Closed
wants to merge 3 commits into from
Closed

Added NumbersClient class #16

wants to merge 3 commits into from

Conversation

jmulford-bw
Copy link
Contributor

closes #12

@jmulford-bw jmulford-bw changed the title Removed serde (will be implemented in another issue) Added NumbersClient class Nov 6, 2018
fuchsnj
fuchsnj previously approved these changes Nov 7, 2018
View reviewed changes
fuchsnj
fuchsnj reviewed Nov 7, 2018
View reviewed changes
src/main/java/com/bandwidth/sdk/numbers/NumbersClient.java
.setScheme(Realm.AuthScheme.BASIC))
.build();

httpClient = asyncHttpClient(httpClientConfig);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to import this function
import static org.asynchttpclient.Dsl.asyncHttpClient;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

NathanNorman
NathanNorman suggested changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@NathanNorman NathanNorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing a build.gradle file that imports the required dependencies

@jmulford-bw
Copy link
Contributor Author

@NathanNorman build.gradle is in master

@fuchsnj fuchsnj requested a review from jdhudson3 November 8, 2018 19:34
@jmulford-bw
Copy link
Contributor Author

Already done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhudson3 jdhudson3 jdhudson3 approved these changes

@fuchsnj fuchsnj fuchsnj approved these changes

@NathanNorman NathanNorman NathanNorman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NumbersClient class
4 participants
@jmulford-bw @NathanNorman @fuchsnj @jdhudson3