Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make compatible with new bal tools release #450

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

gosuto-inzasheru
Copy link
Member

@gosuto-inzasheru gosuto-inzasheru commented Sep 24, 2024

closes #399

@gosuto-inzasheru
Copy link
Member Author

@jalbrekt85 here is one way to deal with BalancerMaxis/bal_tools#41 but you can see how it is a bit weird to pack the dict into a CorePools object, only to then unpack it again. maybe support a to_dict method or something?

@jalbrekt85
Copy link
Contributor

jalbrekt85 commented Sep 24, 2024

@jalbrekt85 here is one way to deal with BalancerMaxis/bal_tools#41 but you can see how it is a bit weird to pack the dict into a CorePools object, only to then unpack it again. maybe support a to_dict method or something?

ya i agree, its a bit unintuitive. i updated to make the class implicitly json serializable, so now can just do json.dump(CorePools) (same as working with dict)

@gosuto-inzasheru
Copy link
Member Author

test run of address book generation: #469

results of pools.json and gauges.json were sanity checked with data team

@gosuto-inzasheru gosuto-inzasheru marked this pull request as ready for review October 3, 2024 10:51
@gosuto-inzasheru gosuto-inzasheru changed the title Issue/399 chore: make compatible with new bal tools release Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: gauges are only included if they are preferential
2 participants