wrong bytes send as file data

[mikolajkubi]

In code of

ICAP-avscan/Java/ICAP/src/icap_samplecode/ICAP.java

Line 187 in 27e147b

while ((fileInStream.read(buffer)) != -1) {

we can see this lines:
while ((fileInStream.read(buffer)) != -1) {
sendString(Integer.toHexString(buffer.length) +"\r\n");
sendBytes(buffer);

But method InputStream.read() may not read full buffer. This method returns the total number of bytes read into the buffer, and this value should be used in next lines. For send string and as parameter for sendBytes() call.
In current state this method is sending additional bytes from buffer which were not filled by read() call.

[Baekalfen]

There might very well be some missing or faulty code. I haven't had access to any ICAP hardware in years, so I rely on others to make pull-requests with fixes.

[lowedown]

I ran into the same issue. By sending the entire buffer instead of only the remaining bytes our ICAP server didn't recognize the eicar.com testfile because it's hash was changed.
Created a PR for the C# client. Someone needs to test and update this for the Java client too.