Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reward frequency for vaults (harvest only 5days, boosted) #2401

Open
mitche50 opened this issue Sep 28, 2022 · 5 comments
Open

update reward frequency for vaults (harvest only 5days, boosted) #2401

mitche50 opened this issue Sep 28, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@mitche50
Copy link
Contributor

Reported on: 2022-09-28T08:37:49.811000+00:00
Bug Description:
The new rETH/WETH vault shouldn't have the rewards frequency as every 2hrs.

Attachments:

@mitche50 mitche50 added the bug Something isn't working label Sep 28, 2022
@mitche50 mitche50 self-assigned this Sep 28, 2022
@mrbasado
Copy link
Collaborator

what should it be? @mitche50

@mitche50
Copy link
Contributor Author

These comments are not actually from me, it's a script (title says who reported it on discord)

In this case, the rewards frequency should say something like

External rewards are distributed on harvest execution, typically every 5 days.
Scheduled distribution rewards are distributed each cycle, typically every 2 hours.

@mrbasado mrbasado assigned mranilrai and unassigned mitche50 Sep 28, 2022
@mranilrai
Copy link
Collaborator

@mitche50 @mrbasado
Currently, all non-Influence vault is showing rewards frequency as every 2hrs. Should I so the new copy to all non-influence vaults, similar to how we show in Influence vaults currently?

Currently in non-Influence vault how we show in Influence vaults currently
Screenshot 2022-09-28 at 10 07 14 PM Screenshot 2022-09-28 at 10 34 59 PM

@mitche50
Copy link
Contributor Author

This is not exactly true either, as those are hard coded. We have 2 different designations of rewards:

  • Scheduled rewards delivered each cycle
  • Harvested rewards delivered approximately every 5 days.

We should probably make that designation, but would require someone to either come up with a dynamic way of expressing this on the UI or hard coding each vault (not ideal)

@okjintao
Copy link
Contributor

if the vault receives badger rewards (schedules) then its 2 hours
the api resports these as Badger Rewards vs. Badger for emitted badger (not from schedules)

this element might need to just be removed / rethought probably - or just have something like

reward types:

  • per harvest: rewards are distributed at each vault harvest - approx every 5 days
  • boosted:
    • per harvest: rewards are distributed at each vault harvest - approx every 5 days
    • scheduled: rewards are distributed every 2 hours based on emission schedule

@mrbasado mrbasado changed the title Discord Bug Report: Kryptobi update reward frequency for vaults (harvest only 5days, boosted) Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants