UST (Wormhole) Vault implementations and test improvements #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajanrajdev
requested review from
GalloDaSballo,
shuklaayush,
tabshaikh and
dapp-whisperer
sajanrajdev
changed the title
4 tasks
tabshaikh
approved these changes
Feb 10, 2022
shuklaayush
approved these changes
Feb 10, 2022
GalloDaSballo
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #24 and 36 from Badger-Strategies
Implementations for the new UST-Wormhole Curve LP vault.
Uses the latest version of the strategy to the cvxCRV handling as well as the bcvxCRV fee event fixes. Fixes introduced on this PR.
Additionally, the PR includes all the improvements made on PR #22:
All tests are passing for the new vault:
Example of harvest:
