Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update badger bridge upgrade scripts #256

Open
wants to merge 1 commit into
base: shake/bridge
Choose a base branch
from

Conversation

okjintao
Copy link
Contributor

@okjintao okjintao commented Feb 11, 2022

  • Deploy logic + proxy bridge contracts, CurveTokenWrapper.sol contract
  • Link proxy and logic contracts
  • Initialize proxy contract with the arguments in the order given below*
  • Update upgrade_bridge script by pasting new CurveTokenWrapper address in “NEW
    CURVETOKENWRAPPER ADDRESS HERE”
  • Run upgrade_bridge.py on multisig
  • Set bridge proxy contract as guest on this contract
    https://etherscan.io/address/0x1b4233242becfd8c1d517158406bf0ed19be2afe
  • Have dfd approve access for new bridge proxy contract on BadgerSettPeak contract
  • Have bCRVibBTC vault approve access for new bridge proxy contract

*Addresses/fees/fee splits for BadgerBridgeAdapter initializer function:
0xb65cef03b9b89f99517643226d76e286ee999e77
0xe95b56685327c9caf83c3e6f0a54b8d9708f32c4
0xe80d347df1209a76dd9d2319d62912ba98c54ddd
0x618591aa0e9a29bec84

@okjintao okjintao added the enhancement New feature or request label Feb 11, 2022
@okjintao okjintao self-assigned this Feb 11, 2022
console.print("[orange]Queued bridge adapter update[/orange]")
# new proxy deployed at
# https://etherscan.io/address/0xd120b381296aa255e4acd9dc80e032df2223fc6a#writeProxyContract
# upgrade_bridge(badger, bridge)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are some of the first steps as per henry's instructions. they were done in a separate deployment before looking here.

@notbdu can you confirm that we can skip these ones i commented out?

my thinking is i only need to do two more things for the new deployed contracts (unless these old ones are correct)

  • changeProxyAdmin to devProxyAdmin on current proxy
  • transferOwnership to devMultisig on badger bridge adapter implementation

then someone will need to execute this script to queue the txs (myself i can do it i think?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the latest OZ proxy contract work with badger's dev proxy admin contract? Might be worth testing that bit in isolation as I'm not sure if they're backwards compatible across versions.

I think if we're deploying a brand new set of contracts + proxy we can remove the upgrade code.

Not sure how much is left to configure in the script below.

We'd need to update all the pointers in the config json to the newly deployed contracts and make sure the tests still run. If there are deploy things to be done, should probably do the following in fork mode:

  • run this upgrade script
  • run all tests while connected to new contract addrs

If tests pass, the script/deploy should be correct.

@okjintao
Copy link
Contributor Author

CurveTokenWrapper
https://etherscan.io/address/0x11e8641b706dbe56298e7b7f54823b00f1182d70

ProxyAdmin (will be changed to dev proxy admin)
https://etherscan.io/address/0xea1573323dcd0a2ddba101eba0b0f0682b0b8b50

BadgerBridgeAdapter Logic
https://etherscan.io/address/0xfe4d003fad9c812cba6d60b07dab8977dce51f85

BadgerBridgeAdapter Proxy
https://etherscan.io/address/0xd120b381296aa255e4acd9dc80e032df2223fc6a

cc: @notbdu for the contract deployment verifications if you see anything wrong those are the ones i'm currently running with

@notbdu
Copy link
Contributor

notbdu commented Feb 11, 2022

I think priority should be making sure the automated tests run against the new addrs (after running any additional setup scripts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants