-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update badger bridge upgrade scripts #256
base: shake/bridge
Are you sure you want to change the base?
Conversation
console.print("[orange]Queued bridge adapter update[/orange]") | ||
# new proxy deployed at | ||
# https://etherscan.io/address/0xd120b381296aa255e4acd9dc80e032df2223fc6a#writeProxyContract | ||
# upgrade_bridge(badger, bridge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are some of the first steps as per henry's instructions. they were done in a separate deployment before looking here.
@notbdu can you confirm that we can skip these ones i commented out?
my thinking is i only need to do two more things for the new deployed contracts (unless these old ones are correct)
changeProxyAdmin
todevProxyAdmin
on current proxytransferOwnership
todevMultisig
on badger bridge adapter implementation
then someone will need to execute this script to queue the txs (myself i can do it i think?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the latest OZ proxy contract work with badger's dev proxy admin contract? Might be worth testing that bit in isolation as I'm not sure if they're backwards compatible across versions.
I think if we're deploying a brand new set of contracts + proxy we can remove the upgrade code.
Not sure how much is left to configure in the script below.
We'd need to update all the pointers in the config json to the newly deployed contracts and make sure the tests still run. If there are deploy things to be done, should probably do the following in fork mode:
- run this upgrade script
- run all tests while connected to new contract addrs
If tests pass, the script/deploy should be correct.
CurveTokenWrapper ProxyAdmin (will be changed to dev proxy admin) BadgerBridgeAdapter Logic BadgerBridgeAdapter Proxy cc: @notbdu for the contract deployment verifications if you see anything wrong those are the ones i'm currently running with |
I think priority should be making sure the automated tests run against the new addrs (after running any additional setup scripts). |
CURVETOKENWRAPPER ADDRESS HERE”
https://etherscan.io/address/0x1b4233242becfd8c1d517158406bf0ed19be2afe
*Addresses/fees/fee splits for BadgerBridgeAdapter initializer function:
0xb65cef03b9b89f99517643226d76e286ee999e77
0xe95b56685327c9caf83c3e6f0a54b8d9708f32c4
0xe80d347df1209a76dd9d2319d62912ba98c54ddd
0x618591aa0e9a29bec84