Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage: Integration tests for tree distribution #503

Open
btcookies opened this issue Jan 14, 2022 · 1 comment
Open

Coverage: Integration tests for tree distribution #503

btcookies opened this issue Jan 14, 2022 · 1 comment
Labels

Comments

@btcookies
Copy link
Contributor

We have an e2e integration test, but we should add in tests that check tree balances before and after and assert that they're increasing how we expect them to. This is especially important for custom handling addresses like badger tree and ibbtc peaks where if rewards are incorrectly distributed it will be at users' expense.

  • sanity check new_token_totals = old_token_totals + expected_token_distribution
  • balance_ibbtc_peak_after == before
  • test for badger tree custom handler
@mitche50
Copy link
Contributor

Wouldn't the second check be balance_ibbtc_msig == before_balance_ibbtc_peak + before_balance_ibbtc_msig?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants