-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set wd fee to 0 on all bsc strats #61
Conversation
@@ -79,7 +79,7 @@ def take_snapshot(self, tokens): | |||
df['decimals'].append(18) | |||
for token in tqdm(tokens): | |||
try: | |||
token = interface.ERC20(token) if type(token) != Contract else token | |||
token = Contract(token) if type(token) != Contract else token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interface.ERC20
doesnt work, because brownie will then also interpret lp tokens as an ERC20, thus excluding the lp methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Confirmed strategies addresses thru controller and underlying tokens in each sett ✅
-
Confirmed gov is
ops_multisig
-
Scripts modifies wd fee to 0, method does not emit event ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed governance on strategies to be:
"ops_multisig": "0x777061674751834993bfBa2269A1F4de5B4a6E7c",
Script LGTM.
Additionally added interface for the Pancake router.
i ran the script as requested and it seems to have loaded:
|
solving #58