Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set wd fee to 0 on all bsc strats #61

Merged
merged 1 commit into from
Jan 28, 2022
Merged

set wd fee to 0 on all bsc strats #61

merged 1 commit into from
Jan 28, 2022

Conversation

gosuto-inzasheru
Copy link
Collaborator

solving #58

@gosuto-inzasheru gosuto-inzasheru requested a review from a team January 28, 2022 16:36
@@ -79,7 +79,7 @@ def take_snapshot(self, tokens):
df['decimals'].append(18)
for token in tqdm(tokens):
try:
token = interface.ERC20(token) if type(token) != Contract else token
token = Contract(token) if type(token) != Contract else token
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface.ERC20 doesnt work, because brownie will then also interpret lp tokens as an ERC20, thus excluding the lp methods.

Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Confirmed strategies addresses thru controller and underlying tokens in each sett ✅

  • Confirmed gov is ops_multisig

  • Scripts modifies wd fee to 0, method does not emit event ✅

Copy link
Collaborator

@sajanrajdev sajanrajdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed governance on strategies to be:
"ops_multisig": "0x777061674751834993bfBa2269A1F4de5B4a6E7c",

Script LGTM.

Additionally added interface for the Pancake router.

@gosuto-inzasheru gosuto-inzasheru merged commit 7ff1067 into main Jan 28, 2022
@gosuto-inzasheru gosuto-inzasheru deleted the issue/56 branch January 28, 2022 19:00
@Tritium-VLK
Copy link
Contributor

Tritium-VLK commented Feb 1, 2022

i ran the script as requested and it seems to have loaded:

Brownie v1.17.0 - Python development framework for Ethereum

Generating interface ABIs...
BadgerMultisigProject is the active project.

Launching 'ganache-cli --accounts 10 --hardfork istanbul --fork https://bsc-dataseed.binance.org --gasLimit 12000000 --mnemonic brownie --port 8545 --chainId 56'...

Running 'scripts/issue/58/disable_wd_fees_bsc.py::main'...
Transaction sent: 0x023f740c646f419be969c905056fb46c54958ec687200f9495d7c896503ef43e
  Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 1
  IStrategy.setWithdrawalFee confirmed   Block: 14861788   Gas used: 15147 (0.13%)

Transaction sent: 0xfc8c43ebbd3dc88aca26899c7f037b7e56b3c041a892d0d79ccf1e58f9a1b02d
  Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 2
  IStrategy.setWithdrawalFee confirmed   Block: 14861789   Gas used: 15147 (0.13%)

Transaction sent: 0xa80fcb3da1895e7a1e2495d9b9f238fd89d3b7e26f854f2eda859c770be38c49
  Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 3
  IStrategy.setWithdrawalFee confirmed   Block: 14861790   Gas used: 15147 (0.13%)

Transaction sent: 0x5c663894187970c73bffc0b84ddb0290164b491924977b7e39d84aaa372cd3af
  Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 0
  Gnosis Safe.approveHash confirmed   Block: 14861788   Gas used: 46206 (0.39%)

Transaction sent: 0xc97ed10e5117185f518544477e034cc94ed9b954c90807f225705b4d83785265
  Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 0
  Gnosis Safe.approveHash confirmed   Block: 14861789   Gas used: 46206 (0.39%)

Transaction sent: 0x88f805310af0223532bd5889dd102fe4810c37eb599c4bb98539042a502d8062
  Gas price: 0.0 gwei   Gas limit: 12000000   Nonce: 0
  Gnosis Safe.approveHash confirmed   Block: 14861790   Gas used: 46206 (0.39%)

Transaction sent: 0x30fe0e9e7f7790ff7782fb24170cff099da36c7307d91aae626df9df78221ade
  Gas price: 0.0 gwei   Gas limit: 139573   Nonce: 1
  Gnosis Safe.execTransaction confirmed   Block: 14861791   Gas used: 45280 (32.44%)

Transaction was Mined 
---------------------
Tx Hash: 0x30fe0e9e7f7790ff7782fb24170cff099da36c7307d91aae626df9df78221ade
From: 0x15b8Fe651C268cfb5b519cC7E98bd45C162313C2
To: 0x777061674751834993bfBa2269A1F4de5B4a6E7c
Value: 0
Function: Gnosis Safe.execTransaction
Block: 14861791
Gas Used: 45280 / 139573 (32.4%)

Events In This Transaction
--------------------------
└── Gnosis Safe (0x777061674751834993bfBa2269A1F4de5B4a6E7c)
    └── ExecutionSuccess
        ├── txHash: 0x40703d18e26b9dbd54626d568525d00db09bfd390c981c7f0e4f6a51f578de86
        └── payment: 0

{
│   'ethereum_client': <gnosis.eth.ethereum_client.EthereumClient object at 0x11bb22940>,
│   'safe_address': '0x777061674751834993bfBa2269A1F4de5B4a6E7c',
│   'to': '0x40A2aCCbd92BCA938b02010E17A5b8929b49130D',
│   'value': 0,
│   'data': HexBytes('0x8d80ff0a0000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000016b00120bb9f87bab3c49b89c7745edc07fed5078653400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024ac1e5025000000000000000000000000000000000000000000000000000000000000000000c8c53a293edca5a0146d713b9b95b0cd0a2e5ca400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024ac1e50250000000000000000000000000000000000000000000000000000000000000000002a842e01724f10d093ae8a46a01e66dbcf3c737300000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024ac1e50250000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000'),
│   'operation': 1,
│   'safe_tx_gas': 107420,
│   'base_gas': 0,
│   'gas_price': 0,
│   'gas_token': '0x0000000000000000000000000000000000000000',
│   'refund_receiver': '0x0000000000000000000000000000000000000000',
│   'signatures': b'',
│   '_safe_nonce': 0,
│   '_safe_version': '1.2.0',
│   '_chain_id': None
}
signer (TrtiumDevKey, TritiumMultisigSubmittor, DevMultisigSubmit, snapshot): TritiumMultisigSubmittor 
Enter password for "TritiumMultisigSubmittor": 
Terminating local RPC client...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants