Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow paladin incentives claims from voter and blend together script for HH + paladin claims in single script conditionally #1484

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

petrovska-petro
Copy link
Collaborator

tackles #1482, paladin's part

run:

brownie run scripts/badger/claim_voter_incentives

…cript for HH + paladin claims in single script conditionally
Copy link
Collaborator

@sajanrajdev sajanrajdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Introduces methods to claim from Paladin quests from the Voter multisig
  • Confirmed api endpoint and data
  • Changes the voter's incentives claims script for a new one that includes both HH and Paladin's claiming. Script transfers all balance of LIQ and BADGER to trops. Makes sense to transfer full voter balance as it is not intended to hold naked LIQ nor BADGER. All of these assets are assumed to be coming from this source and, therefore, makes sense to return them to trops for further influence operations.
  • Events and snapshot confirm proper functioning:
snapshot result for 0x042B32Ac6b453485e357938bdC38e0340d4b9276:
                    balance_before               balance_after              balance_delta
symbol
BADGER  184,530.407958751309074378  184,796.729180052900659519     266.321221301591585141
LIQ      60,418.806255161722986058  105,513.894202895980276762  45,095.087947734257290704

LGTM

sajanrajdev
sajanrajdev previously approved these changes Jan 17, 2024
@petrovska-petro
Copy link
Collaborator Author

TODO: will need to dig deeper into this script again since, it seems that the data from paladin b/e never expires so it cointains also proofs that were actually claimed, so there needs to be some diff or simply just take latest

@petrovska-petro petrovska-petro linked an issue Feb 16, 2024 that may be closed by this pull request
@petrovska-petro
Copy link
Collaborator Author

closes #1510 as well

Copy link
Collaborator

@sajanrajdev sajanrajdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple script to claw back incentives from Paladin was introduced.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support claiming back withdrawable rewards from quests
2 participants