Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/delever fix #1464

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Feat/delever fix #1464

merged 4 commits into from
Dec 6, 2023

Conversation

sajanrajdev
Copy link
Collaborator

Tackles #1463

  • Adapts script to realize gains in terms of USDC (partially through delevering withdrawal and partially through a final difference sale on Cowswap
  • Fixes UniV3 class min out (slippage was wrongly estimated)

rayeaster
rayeaster previously approved these changes Dec 6, 2023
View reviewed changes
Copy link

@rayeaster rayeaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajanrajdev sajanrajdev requested a review from rayeaster December 6, 2023 13:00
petrovska-petro
petrovska-petro approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swaps the wbtc denominated gains granularly based on the deposited 5 wbtc into stablecoin via cow ✅

rayeaster
rayeaster approved these changes Dec 6, 2023
View reviewed changes
Copy link

@rayeaster rayeaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajanrajdev sajanrajdev merged commit 027ac60 into main Dec 6, 2023
3 checks passed
@sajanrajdev sajanrajdev deleted the feat/delever-fix branch December 6, 2023 13:07
@sajanrajdev sajanrajdev mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrovska-petro petrovska-petro petrovska-petro approved these changes

@rayeaster rayeaster rayeaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sajanrajdev @rayeaster @petrovska-petro