Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inquisition Kill Team #845

Closed
9 tasks done
Mad-Spy opened this issue Aug 8, 2023 · 4 comments
Closed
9 tasks done

Add Inquisition Kill Team #845

Mad-Spy opened this issue Aug 8, 2023 · 4 comments

Comments

@Mad-Spy
Copy link
Collaborator

Mad-Spy commented Aug 8, 2023

New stuff

  • Add Inquisition operatives
  • Add Sisters of Silence operatives
  • Add Tempestus Scions
  • Add Equipment
  • Add Battle Honours

Operatives from other teams

  • Exaction Squad
  • Imperial Navy Breachers
  • Kasrkin
  • Vet Guardsman
@Bagel210
Copy link

Bagel210 commented Oct 9, 2023

Could you push up the PR for this so others could potentially build on it? This has been open for a while and would be great to get this closed.

@Mad-Spy
Copy link
Collaborator Author

Mad-Spy commented Oct 9, 2023

It's stalled because the implementation for the Kill Team data wasn't designed to have models pulled in from other catalogues, because that concept didn't exist prior to Inquisition.

Ideally, the 4 catalogues above would get rewritten to support their models being shared across to Inquisition. This makes things more easily maintainable in the future when the other catalogues have changes made (after a data-slate, for instance). However, this would break every existing list made with those 4 catalogues.

The other option is to copy everything into Inquisition, which then makes maintaining the data in the future more of a pain, and is non-trivial in itself.

Either way, it's several hours work per catalogue.

@Bagel210, are you offering to do this work? Do you have any prior experience in working on BS data files?

There are currently only 2 of us supporting this system, for free, in our spare time. If you're offering to help out, that's great.
Otherwise, it'll be finished when I have the time to spare to do the required work.

@Bagel210
Copy link

Bagel210 commented Oct 9, 2023

Ahh that makes sense! That’s really annoying and there isn’t a great solution to it as you say.

I don’t have prior experience at this time but was looking to see if I can contribute to help out where I can - hence why I was looking to see if there was a pull request I could work try and work off.

@mal20k mal20k self-assigned this Dec 29, 2023
@mal20k
Copy link
Collaborator

mal20k commented Dec 29, 2023

I've gotten around to working on this. Have the Breachers and Kasrkin with basic links on the branch so far.

@mal20k mal20k closed this as completed in 01ff0b8 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants