Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to read files in node_modules #203

Open
cfengsequoia opened this issue Jan 28, 2022 · 1 comment
Open

Is it possible to read files in node_modules #203

cfengsequoia opened this issue Jan 28, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cfengsequoia
Copy link

cfengsequoia commented Jan 28, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
I need to read files from node_modules which contain jsdoc definitions of components, but it's not allowed.

Describe the solution you'd like
Add a new option excludedFolder to cover default param DEFAULT_EXCLUDED_FOLDER of function globFilesMatches.
@cfengsequoia cfengsequoia changed the title Option excludedFolder needed to read files in node_modules Is it possible to allow that reading files in node_modules Jan 28, 2022
@cfengsequoia cfengsequoia changed the title Is it possible to allow that reading files in node_modules Is it possible to read files in node_modules Jan 28, 2022
@kevinccbsg kevinccbsg added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 18, 2022
@kevinccbsg
Copy link
Member

Hi @cfengsequoia maybe we could include a flag to ignore that. The problem we had when we don not ignore the node_modules was that there were memory issues while reading the node_modules. We will try to add a flag in the config.

We don't have time to do it soon but we will keep it in our backlog. Thanks for reporting 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinccbsg @cfengsequoia