Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptor sanity checks #33

Open
dr-orlovsky opened this issue Jul 22, 2024 · 0 comments · May be fixed by #35
Open

Add descriptor sanity checks #33

dr-orlovsky opened this issue Jul 22, 2024 · 0 comments · May be fixed by #35
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dr-orlovsky
Copy link
Member

Right now users can provide library with invalid xpubs doesn't matching the descriptor requirements in many ways. For instance, they can mix testnet and mainnet derivations, contain custom, non-complete or different keychain segments, provide zeros as master fingerprint (which will result in PSBTs failing to be signed with most hardware wallets) etc.

Descriptor trait need to have a check_sanity method detecting such issues and allowing library users to report them to the user upon the wallet creation.

@dr-orlovsky dr-orlovsky added the enhancement New feature or request label Jul 22, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Jul 22, 2024
@dr-orlovsky dr-orlovsky self-assigned this Jul 22, 2024
@dr-orlovsky dr-orlovsky changed the title Add descriptor checks Add descriptor sanity checks Jul 24, 2024
@dr-orlovsky dr-orlovsky moved this to In progress in RGB release v0.11 Jul 24, 2024
@dr-orlovsky dr-orlovsky linked a pull request Aug 18, 2024 that will close this issue
@dr-orlovsky dr-orlovsky modified the milestones: v0.11.0, v0.12.0, v0.11.x Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant