Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eDNA is here! #109

Open
mkoo opened this issue Dec 14, 2020 · 3 comments
Open

eDNA is here! #109

mkoo opened this issue Dec 14, 2020 · 3 comments
Labels
Priority this is important! question Further information is requested Submitted Data issue related to a record in a project

Comments

@mkoo
Copy link
Member

mkoo commented Dec 14, 2020

I thought we would tackle this eventually-- looks like now is good.

We have a few samples of eDNA uploaded (https://geome-db.org/workbench/project-overview?projectId=365). I will be contacting the project owner, but meanwhile here's a few tweaks we need on our side.

  • add new sampleType = water and soil
  • in required genus field, I think we need to allow non-generic value to indicate eDNA, otherwise the api cannot chart since it fails taxonomy-checks. I suggest allowing genus = eDNA or similar, allow specificEpithet = NULL

@jdeck88 thoughts on last point?

@mkoo mkoo added Priority this is important! Submitted Data issue related to a record in a project labels Dec 14, 2020
@jdeck88
Copy link
Member

jdeck88 commented Dec 14, 2020 via email

@mkoo
Copy link
Member Author

mkoo commented Dec 14, 2020

However, "Unknowns" get tossed out of charts and still assumes there is an organism associated with the sample. Unless we can conditionally have basisofRecord= MaterialSample, then genus=unknown could be included in a chart. Seems like a lot of rules still. (btw, the user did use MaterialSample for basisofRecord)

How about genus =  Sample ? then we can still include these data in a histogram and other charts. 

What would be easier to graph @birbjam ? if genus = unknown and basisofRecord= MaterialSample, then display those separately as eDNA records? Or if genus = Sample

here's the use case: https://amphibiandisease.org/projects/?id=365

@mkoo mkoo added the question Further information is requested label Jan 4, 2021
@mkoo
Copy link
Member Author

mkoo commented Jan 28, 2021

Following up on this issue as I would like to write up guidelines and contact our friends at the above project...

  • sampleType is straightforward as its controlled vocab, not defined by Geome -- I will update.

  • Can we tweak Genus to allow Sample or Other as I think Unknown is inaccurate or misleading. @jdeck88

  • and lastly can charts be changed to allow these conditions listed above? @birbjam

Let me know if we need to reserve this for a chat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority this is important! question Further information is requested Submitted Data issue related to a record in a project
Projects
None yet
Development

No branches or pull requests

2 participants