-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigWarp 9.0.0 coming #177
Comments
Thanks for warning! I saw a big PR on your repo indeed, this looks great! Do you have a potential release date ? Side note: I saw some commits about transform serialization. Is it something I should adopt ? Are there some demo somewhere ? Cheers |
It would be great if you could eventually adopt the transform serialization ❤️
Exactly. My next job is to document and make examples for this stuff. I can let you know when that's ready, and I'd value your feedback! |
I released bigwarp-9.0.0 earlier this week. It won't go into Fiji yet though - I want to wait until we're confident this repo and whatever other dependencies work with it. So when you have some time, please give it a try. As I said, compilation was smooth, so I'm hopeful that the functionality won't cause many problems - and I will be happy to help figure out any issues that arise. p.s. There are a couple bugs I found and fixed already (of course), so there will be a 9.0.1 soon, and it should include anything we find while testing integration. Thanks! |
Hi @bogovicj , I gave a try in the downstream repo bigdataviewer-playground, which is the one used in this repo. There's a bigwarp-9 branch, https://github.com/bigdataviewer/bigdataviewer-playground/tree/bigwarp-9 and two self-contained demos for BigWarp:
Unfortunately, so far, none are working. For BigWarp2DTest I get this error:
and for BigWarpDemo, I get a weird BDV error, probably happening at the initialisation. Then the deformation live update is not working anymore. If you want to know what's the expected behaviour you can checkout the master branch. Would you have time to have a look ? If that's easier maybe we can have a quick check together in zoom ? Cheers |
Thanks @NicoKiaru ! I'll have a look soon, and if I'm confused we'll arrange for a zoom talk. |
Looked to me like both of those issues needed fixes in BW, and the BdvPlayground stuff should be fine as is. One fix for Thanks again for those examples |
Good catch - I missed that. Fixed it! |
Mostly done, one thing left, it's #195 This is a functionality that's here for performance only, so I'll move on anyway |
Hi @NicoKiaru ,
It's been on the way for awhile, but I will make a new major release of BigWarp soon:
saalfeldlab/bigwarp#163
While there are lots of changes, most of the high-level API is still the same. I just tried building this repo with the development version, and it compiled without a problem.
Please let me know how I can help, and if there are other repos that might need testing.
(I'll be able to test building code, but won't be very helpful in testing functionality).
The text was updated successfully, but these errors were encountered: