Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Information about Notification Configuration #871

Open
MattMatt27 opened this issue Dec 11, 2024 · 2 comments
Open

Additional Information about Notification Configuration #871

MattMatt27 opened this issue Dec 11, 2024 · 2 comments
Assignees
Labels
priority MEDIUM Medium priority item question Question about existing features or bugs

Comments

@MattMatt27
Copy link
Contributor

MattMatt27 commented Dec 11, 2024

I am hoping to learn a little more about how our notification system is currently working.

In our documentation, it claims that we are required to configure an allowed list of API_KEYS in the LAMP-app-gateway container and the PUSH_API_KEY environment variable of LAMP-server must be included in the list of allowed API_KEYS. That logic appears to have been implemented here: https://github.com/BIDMCDigitalPsychiatry/LAMP-app-gateway/blob/24e29f3837712160e934de0326f93b1da377b99e/app.js#L192 and here: https://github.com/BIDMCDigitalPsychiatry/LAMP-server/blob/fe6fe8df31dcaecd82481a99f2c1f4e317466c9d/src/utils/queue/PushNotificationQueue.ts#L27

In our existing environment those keys are not currently configured correctly, but the notifications are still working. I was wondering if there is workaround that is sending out notifications without hitting the push endpoint in the gateway. Would it be possible that redis or the ios/android implementations themselves are handling notifications in another way? In the LAMP-core-ios repo I found this section of code for example: https://github.com/BIDMCDigitalPsychiatry/LAMP-core-ios/blob/e53a9ce39ef59bcd65e7734a25c1628b47508ea3/mindLAMP/Push%20Notification/UserNotifications.swift#L15

There are no code change requests associated with this ticket. I am just looking for enough information on how notifications are configured so that I can update our notification documentation.

@MattMatt27 MattMatt27 added the question Question about existing features or bugs label Dec 11, 2024
@ZCOEngineer
Copy link

Hi @MattMatt27 is this a separate LAMP server installation?

@MattMatt27
Copy link
Contributor Author

This is for the LAMP server instance currently in use by our team in Docker. I believe it is running on code from the most recent release https://github.com/BIDMCDigitalPsychiatry/LAMP-server/releases/tag/2023.7.27 and not master if that is helpful context.

@MattMatt27 MattMatt27 added the priority MEDIUM Medium priority item label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority MEDIUM Medium priority item question Question about existing features or bugs
Projects
None yet
Development

No branches or pull requests

3 participants