Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolutionary model bibcodes not being added to refs dictionary #142

Open
SherelynA opened this issue Nov 22, 2024 · 3 comments
Open

Evolutionary model bibcodes not being added to refs dictionary #142

SherelynA opened this issue Nov 22, 2024 · 3 comments

Comments

@SherelynA
Copy link
Collaborator

SherelynA commented Nov 22, 2024

I feel like this info is somewhere, and if it is I think it should be easier to find what the references are for the evolutionary models. @hover2pi you probably have a better idea about if this is somewhere in the code. I think we should make it so that the reference for the evolutionary model is added to the sed the moment you choose one.

@hover2pi
Copy link
Member

hover2pi commented Nov 22, 2024

It's just the references to the publications for now. You can see the references used for a given SED by calling the s.refs attribute. When you add data or use an evo or atmo model, it adds the reference to the refs dictionary. Were you looking for something more like documentation?

@SherelynA
Copy link
Collaborator Author

@hover2pi, yes it adds the evo model to the s.refs but it doesn't add the reference itself for the evo model to s.refs. So for example, it would say the bibcode for the evolutionary model being used.

@hover2pi
Copy link
Member

@SherelynA Oh, we need to add that then. For the time being, the nc_solar_age evo model reference should be:

D. Saumon and M. S. Marley. The Evolution of L and T Dwarfs in Color-Magnitude Di- agrams. Astrophysical Journal, 689(2):1327–1344, dec 2008. doi: 10.1086/592734. URL http://dx.doi.org/10.1086/592734.

@hover2pi hover2pi changed the title documentation on evolutionary models Evolutionary model bibcodes not being added to refs dictionary Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants