Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sedkit.Spectrum with specutils.Spectrum #138

Open
kelle opened this issue Nov 15, 2024 · 2 comments
Open

Replace sedkit.Spectrum with specutils.Spectrum #138

kelle opened this issue Nov 15, 2024 · 2 comments

Comments

@kelle
Copy link
Member

kelle commented Nov 15, 2024

Lots of functionality in spectrum.py should be replaced with specutils.
https://specutils.readthedocs.io/en/stable/

@hover2pi
Copy link
Member

hover2pi commented Nov 15, 2024

This is doable but I suspect will be a LOT of work. Do we get more accurate results with specutils or is this more about UX? I'm not opposed, just wary.

@kelle
Copy link
Member Author

kelle commented Nov 15, 2024

First, this is definitely not high priority.

It's about sustainability. There are many tests for the functionality of Spectrum which are handled by specutils (trim, add, normalize, etc).

For folks potentially wanting to contribute, they are more likely to be familiar with the specutils.Spectrum class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants