Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new environment for 2024-3 cycle #316

Merged
merged 14 commits into from
Oct 23, 2024
Merged

new environment for 2024-3 cycle #316

merged 14 commits into from
Oct 23, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Aug 19, 2024

@prjemian prjemian added the task routine work label Aug 19, 2024
@prjemian prjemian added this to the v1.0.4 milestone Aug 19, 2024
@prjemian prjemian self-assigned this Aug 19, 2024
@prjemian
Copy link
Contributor Author

CI workflow failure from failed ruff check. Also: %run -i ~/bluesky/user/quick_hello.py not found.

@prjemian
Copy link
Contributor Author

Suspend ruff lint check for now.

@coveralls
Copy link

coveralls commented Sep 20, 2024

Pull Request Test Coverage Report for Build 10964444127

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.197%

Totals Coverage Status
Change from base Build 9847941795: 0.0%
Covered Lines: 1020
Relevant Lines: 1226

💛 - Coveralls

@prjemian prjemian marked this pull request as ready for review September 20, 2024 15:18
@prjemian
Copy link
Contributor Author

Also note the root level environment.yml file duplicates (somewhat) the content in ./bluesky/environments/environment*.yml. Maybe it should be much lighter, just what is necessary for this project and not a general run-time package environment for users?

@prjemian
Copy link
Contributor Author

prjemian commented Sep 20, 2024

Maybe ...should be much lighter...

This repo serves several purposes:

  • demonstrate use of the Bluesky framework at a typical APS beamline
  • documentation
  • user training
  • template for new installations at APS beamlines

As-is, the environment file provides a run-time suite of software supporting various user activities during and after data collection. If any substantial changes now, make the project's environment.yml match the latest one in ./bluesky/environments/environment*.yml.

@prjemian
Copy link
Contributor Author

@rodolakis , @MDecarabas : Ready for review. Can wait until we meet again. Meanwhile, I will start using locally.

@prjemian
Copy link
Contributor Author

prjemian commented Oct 9, 2024

README.md needs to be updated.

@prjemian prjemian merged commit e4f4f59 into main Oct 23, 2024
6 checks passed
@prjemian
Copy link
Contributor Author

@MDecarabas Thanks!

@prjemian prjemian deleted the 215-env-2024_3 branch October 23, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task routine work
Projects
No open projects
3 participants