Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxi/fly example with busy records #248

Merged
merged 28 commits into from
Apr 3, 2024
Merged

taxi/fly example with busy records #248

merged 28 commits into from
Apr 3, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added the documentation Improvements or additions to documentation label Oct 23, 2023
@prjemian prjemian added this to the v1.0.2 milestone Oct 23, 2023
@prjemian prjemian self-assigned this Oct 23, 2023
@prjemian
Copy link
Contributor Author

Might be more useful if added a second example using sscan record and collecting data.

@prjemian
Copy link
Contributor Author

Also, this is more an example than a HOWTO. Moving...

@prjemian
Copy link
Contributor Author

unit test failure:

Run CMD="import ophyd"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/runner/micromamba/envs/anaconda-test-env-py-3.8/lib/python3.8/site-packages/ophyd/__init__.py", line 92, in <module>
    from .areadetector import *  # noqa: F401, F402, E402, F403
  File "/home/runner/micromamba/envs/anaconda-test-env-py-3.8/lib/python3.8/site-packages/ophyd/areadetector/__init__.py", line 7, in <module>
    from .base import *  # noqa: F401, F402, E402, F403
  File "/home/runner/micromamba/envs/anaconda-test-env-py-3.8/lib/python3.8/site-packages/ophyd/areadetector/base.py", line [22](https://github.com/BCDA-APS/bluesky_training/actions/runs/6619635192/job/17980549611?pr=248#step:12:23), in <module>
    import networkx as nx
  File "/home/runner/micromamba/envs/anaconda-test-env-py-3.8/lib/python3.8/site-packages/networkx/__init__.py", line 35, in <module>
    from networkx import generators
  File "/home/runner/micromamba/envs/anaconda-test-env-py-3.8/lib/python3.8/site-packages/networkx/generators/__init__.py", line 5, in <module>
    from networkx.generators.atlas import *
  File "/home/runner/micromamba/envs/anaconda-test-env-py-3.8/lib/python3.8/site-packages/networkx/generators/atlas.py", line 54, in <module>
    ATLAS_FILE = importlib.resources.files("networkx.generators") / "atlas.dat.gz"
AttributeError: module 'importlib.resources' has no attribute 'files'
Error: Process completed with exit code 1.

@prjemian
Copy link
Contributor Author

Web search suggests an answer: jsonschema >= 4 breaks conda

Review these reports that resolved this problem elsewhere.

@prjemian
Copy link
Contributor Author

In this case, these versions:

2023-10-23T22:15:53.1899155Z   jsonschema                     4.19.1        pyhd8ed1ab_0            conda-forge
2023-10-23T22:15:53.1900357Z   jsonschema-specifications      2023.7.1      pyhd8ed1ab_0            conda-forge
2023-10-23T22:15:53.1901614Z   jsonschema-with-format-nongpl  4.19.1        pyhd8ed1ab_0            conda-forge
2023-10-23T22:15:53.2213870Z   python-fastjsonschema          2.18.1        pyhd8ed1ab_0            conda-forge

@prjemian
Copy link
Contributor Author

Note the previous unit test failure did not recur. Assume it was a transient problem.

@prjemian prjemian marked this pull request as draft February 16, 2024 15:16
@prjemian prjemian modified the milestones: v1.0.2, v1.0.3 Feb 24, 2024
@coveralls
Copy link

coveralls commented Feb 26, 2024

Pull Request Test Coverage Report for Build 8543743070

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 82.675%

Files with Coverage Reduction New Missed Lines %
bluesky/instrument/devices/temperature_signal.py 1 93.22%
Totals Coverage Status
Change from base Build 8054742528: -0.07%
Covered Lines: 983
Relevant Lines: 1189

💛 - Coveralls

@prjemian prjemian marked this pull request as ready for review March 19, 2024 23:01
@prjemian
Copy link
Contributor Author

@prjemian
Copy link
Contributor Author

Seems more natural to override the busy.trigger() method instead of making a new busy.set(v) method where the v argument is ignored.

@prjemian
Copy link
Contributor Author

This CI error seems transient. Ignoring for now.

Copy link
Collaborator

@MDecarabas MDecarabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prjemian prjemian merged commit f417218 into main Apr 3, 2024
7 checks passed
@prjemian prjemian deleted the 247-howto-busy-taxi-fly branch April 3, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Fly scans with taxi & fly busy records
3 participants