-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta version #1
base: master
Are you sure you want to change the base?
Beta version #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See individual comments for specific tips. Generally separate the script into more files, improve readability, add unit tests, add instructions for running it localy.
conversion_to_fhir.py
Outdated
import xml.etree.ElementTree as ElementTree | ||
|
||
|
||
class Patient: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the data model classes into separate files
conversion_to_fhir.py
Outdated
create_specimen(patient.identifier, specimen, number) | ||
|
||
|
||
def create_patient(patient, number): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use smart-on-fhir: https://github.com/smart-on-fhir/client-py for creating the FHIR Resources.
conversion_to_fhir.py
Outdated
|
||
tree = ElementTree.ElementTree(root) | ||
xml_file_path = "patient_" + number + ".fhir.xml" | ||
tree.write(xml_file_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the FHIR validator for validating the resources: https://hl7.org/fhir/validator/
omop_conversion.py
Outdated
from datetime import datetime, timedelta | ||
|
||
|
||
class Patient: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated code
omop_conversion.py
Outdated
'password': '', | ||
} | ||
|
||
cdm_schema = [""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where did you get the schema from?
Hi,
this is my first draw, maybe I will change it soon and add commits.